Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/ssmtp: add settings option #89662

Merged
merged 2 commits into from Jun 12, 2020
Merged

nixos/ssmtp: add settings option #89662

merged 2 commits into from Jun 12, 2020

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Jun 6, 2020 •
edited

Motivation for this change

#89594

I'm not sure if I'm currently running ssmtp on any machines so I didn't test the execution of the program, though I did validate ssmtp.conf is equivalent before and after this change with a few example configurations.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member Author

aanderse commented Jun 6, 2020

ping @sjau for testing and approval. Usage as follows:

services.ssmtp.enable = true;
services.ssmtp.hostName = "mail.example.org";
...
services.ssmtp.settings = {
  Debug = true;
  # NOTE: you can set any value ssmtp.conf accepts here
};

@sjau
Copy link

sjau commented Jun 6, 2020

ping @sjau for testing and approval. Usage as follows:

For me it's fine. I just wanted to be able to also debug if necessary :)

Ma27
Ma27 approved these changes Jun 7, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Apart form two minor this seems fine to me :)

nixos/modules/programs/ssmtp.nix Outdated Show resolved Hide resolved
nixos/modules/programs/ssmtp.nix Outdated Show resolved Hide resolved
@aanderse
Copy link
Member Author

@Ma27 after the bot finishes I'll look to you for final approval and merge. Thank you!

@Ma27 Ma27 merged commit 267b93d into NixOS:master Jun 12, 2020
@aanderse aanderse deleted the ssmtp branch June 13, 2020 22:54
@aanderse aanderse mentioned this pull request Jun 20, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjau sjau sjau left review comments

@JohnAZoidberg JohnAZoidberg JohnAZoidberg left review comments

@Ma27 Ma27 Ma27 approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aanderse @sjau @JohnAZoidberg @Ma27