Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: pip install flags are specified with pipInstallFlags #89624

Merged
merged 1 commit into from Jun 16, 2020
Merged

doc: pip install flags are specified with pipInstallFlags #89624

merged 1 commit into from Jun 16, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Jun 6, 2020

Motivation for this change

The documentation incorrectly stated that installFlags are passed to
pip install.

nixpkgs/pkgs/development/interpreters/python/hooks/pip-install-hook.sh

Line 14 in 8de15ac

@pythonInterpreter@ -m pip install ./*.whl --no-index --prefix="$out" --no-cache $pipInstallFlags --build tmpbuild

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
doc: pip install flags are specified with pipInstallFlags
ce99697 
The documentation incorrectly stated that `installFlags` are passed to
`pip install`.
@danieldk danieldk requested a review from FRidh as a code owner June 6, 2020 10:47
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/194

@FRidh FRidh merged commit 58ec4d5 into NixOS:master Jun 16, 2020
@danieldk danieldk deleted the python-doc-install-flags branch June 16, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @nixos-discourse @FRidh