New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xdg-desktop-portal-wlr: init at 0.1.0 #83485
Conversation
I don't use wayland but I could give it try with the VM and Jitsi Meet screen sharing. |
489b496
to
5533777
Compare
@minijackson can you give some context here? I assume Pipewire 0.3+ isn't part of 20.03, so no chance we would be able to backport this, right? |
@minijackson I don't think GNOME 3.36 will be backported - I'm wondering if we could just backport the required bits for getting this to work to 20.03 (as it'd be really nice to get screensharing on wayland to work). Anyways, you're right - let's first see if it works, and then talk about backporting 😆 |
So, I managed to build (took a while to compile firefox) and run the VM with your configuration. |
Ah, no I thought it had already been merged. I'll try again with that patch soon. |
I don't think we could backport pipewire_0_3 as a new package either. |
wlroots 0.10.1 and pipewire 0.3.2 are now in unstable, so you can rebase this pull request. The failure on aarch64-linux looks like a problem in a dependency, so that should be fixed on rebase (though I don't have any aarch64 hardware to test with yet). |
5533777
to
6db1d74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed an update to v0.1.0 that was released since this package first started to be packaged here.
I've tested this out - but can't get it to work with either Firefox or Chromium. I'm guessing because neither are currently compiled with pipewire support, correct? |
I'm also not able to have this working. I think I'm missing some pieces, I see that the package provide some systemd units, which I guess we should install too. |
This is correct for Firefox, it needs a patch from Fedora, which is in a PR for nixpkgs at #84233. As for Chromium 73+ the Arch wiki says the feature is behind the |
It looks like the NixOS chromium package isn't built with RTC_USE_PIPEWIRE=true which adds that flag. |
Let's merge this and address Firefox and Chromium changes separately |
This provides the browser flag #enable-webrtc-pipewire-capturer, which adds support for screensharing on Wayland via xdg-desktop-portal. The browser flag is disabled by default until a user enables it. At least one other major distribution (Arch) enables this compile time option, and so I believe it should be safe to enable by default. This is also needed to support xdg-desktop-portal-wlr which was added in NixOS#83485.
dependencies updates. ## Changelog for nixpkgs: Commits: [NixOS/nixpkgs@f7036e2c...dcb64ea4](NixOS/nixpkgs@f7036e2...dcb64ea) * [`5262ada4`](NixOS/nixpkgs@5262ada) palemoon: 28.9.1 -> 28.9.3 * [`5a94a29e`](NixOS/nixpkgs@5a94a29) mpd: use pkg-config instead of pkgconfig * [`ecdbbdf1`](NixOS/nixpkgs@ecdbbdf) mpd: format inputs * [`69aa4f37`](NixOS/nixpkgs@69aa4f3) mpd: enable tests * [`08bdd8bc`](NixOS/nixpkgs@08bdd8b) mpd: Build and install docs and split outputs * [`f3352f32`](NixOS/nixpkgs@f3352f3) maintainers: add lunik1 * [`a46d7f2d`](NixOS/nixpkgs@a46d7f2) openorienteering-mapper: 0.9.2 -> 0.9.3 * [`4eb8f4ec`](NixOS/nixpkgs@4eb8f4e) aflplusplus: 2.64c -> 2.65c * [`5f19ec3b`](NixOS/nixpkgs@5f19ec3) aflplusplus: don't run unit tests with cmocka * [`d478d7a6`](NixOS/nixpkgs@d478d7a) aflplusplus: remove clang_9 and llvm_9 specificity * [`067a26a4`](NixOS/nixpkgs@067a26a) easyrpg-player: 0.6.1 -> 0.6.2 * [`b7eec6ad`](NixOS/nixpkgs@b7eec6a) wownero: 0.7.0 -> 0.8.0.0 * [`b7a8c4d8`](NixOS/nixpkgs@b7a8c4d) bazel-watcher: 0.13.0 -> 0.13.1 * [`ed73bb8d`](NixOS/nixpkgs@ed73bb8) freerdp: 2.1.0 -> 2.1.1 * [`009284cd`](NixOS/nixpkgs@009284c) displaycal: 3.5 -> 3.8.9.3 * [`7fc97cf3`](NixOS/nixpkgs@7fc97cf) idris2: 0.2.0-840e020 -> 0.2.0 * [`e0c0c1f0`](NixOS/nixpkgs@e0c0c1f) bitwig-studio3: 3.1.2 -> 3.1.3 * [`3704ed17`](NixOS/nixpkgs@3704ed1) vscode-utils: remove extra whitespace * [`0717848d`](NixOS/nixpkgs@0717848) vscode-with-extensions: fix extension directory * [`c906c45f`](NixOS/nixpkgs@c906c45) gazebo, sdformat: remove * [`a410beaa`](NixOS/nixpkgs@a410bea) ignition-transport: remove * [`f9622e30`](NixOS/nixpkgs@f9622e3) ignition-math: remove * [`3b26ba8b`](NixOS/nixpkgs@3b26ba8) maintainers: remove pxc * [`4f99c572`](NixOS/nixpkgs@4f99c57) vscode-extensions.vscode-utils: reapply some changes from bb24faf * [`094bd40d`](NixOS/nixpkgs@094bd40) plex: 1.19.2.2737-b69929dab -> 1.19.3.2852-219a9974e * [`557a4df3`](NixOS/nixpkgs@557a4df) tachyon: install header files * [`f7651f70`](NixOS/nixpkgs@f7651f7) skaffold: 1.9.1 -> 1.10.1 * [`0332c063`](NixOS/nixpkgs@0332c06) coz: fix python shebang * [`07d3ca81`](NixOS/nixpkgs@07d3ca8) sane-airscan: 0.99.0 -> 0.99.3 * [`c7eb16ce`](NixOS/nixpkgs@c7eb16c) qemu: wrap GTK binaries * [`5db5b25c`](NixOS/nixpkgs@5db5b25) php.extensions: Apply patches from the php source root by default * [`2e0d4a8b`](NixOS/nixpkgs@2e0d4a8) php.extensions.mysqlnd: Fix compression support * [`654d1ca4`](NixOS/nixpkgs@654d1ca) olive-editor: use wrapQtAppsHook * [`6031391c`](NixOS/nixpkgs@6031391) maintainers: add seb314 * [`24227ad1`](NixOS/nixpkgs@24227ad) jamulus: init at 3.5.5 * [`da540dbb`](NixOS/nixpkgs@da540db) libreoffce-qt: init at 6.4.3.2 * [`cd712e62`](NixOS/nixpkgs@cd712e6) bazel-buildtools: 2.2.1 -> 3.2.0 * [`6d651f2b`](NixOS/nixpkgs@6d651f2) rubberband: 1.8.1 -> 1.8.2 * [`056089e7`](NixOS/nixpkgs@056089e) syncthing: 1.5.0 -> 1.6.1 * [`04094d7d`](NixOS/nixpkgs@04094d7) mint-x-icons: init at 1.5.5 * [`0de586eb`](NixOS/nixpkgs@0de586e) factorio{,-headless}-experimental: 0.18.26 -> 0.18.29 * [`e5d33f6d`](NixOS/nixpkgs@e5d33f6) fdkaac: init at 1.0.0 * [`f1bf95f8`](NixOS/nixpkgs@f1bf95f) grafana: 7.0.2 -> 7.0.3 * [`3b343be7`](NixOS/nixpkgs@3b343be) wasabiwallet: 1.1.9.2 -> 1.1.11.1 * [`bf1c120e`](NixOS/nixpkgs@bf1c120) python3Packages.cookiecutter: add missing slugify dependency * [`7f87a170`](NixOS/nixpkgs@7f87a17) thunderbird-bin: 68.8.1 -> 68.9.0 * [`5967e4d8`](NixOS/nixpkgs@5967e4d) thunderbird: 68.8.1 -> 68.9.0 * [`8da7b450`](NixOS/nixpkgs@8da7b45) owslib: add pyyaml as a runtime dep * [`2d38b582`](NixOS/nixpkgs@2d38b58) watchexec: 1.12.0 -> 1.13.0 * [`cc1f954b`](NixOS/nixpkgs@cc1f954) ocamlPackages.elpi: 1.10.2 -> 1.11.0 * [`fc255531`](NixOS/nixpkgs@fc25553) slirp4netns: 1.0.1 -> 1.1.0 * [`7384e9b2`](NixOS/nixpkgs@7384e9b) goldendict: 2020-01-09 -> 2020-05-27 * [`8f9e4bef`](NixOS/nixpkgs@8f9e4be) Bump minver.nix to 2.2 * [`bbfc4732`](NixOS/nixpkgs@bbfc473) Don't enable nix-bash-completions when using Nix 2.4 * [`79454f15`](NixOS/nixpkgs@79454f1) gitlab: 12.10.8 -> 13.0.3 * [`0b5c5345`](NixOS/nixpkgs@0b5c534) gitlab: 13.0.3 -> 13.0.4 * [`d8040e24`](NixOS/nixpkgs@d8040e2) overmind: 2.0.3 -> 2.1.1 * [`2379e361`](NixOS/nixpkgs@2379e36) python39: fix build on macOS * [`c51202ff`](NixOS/nixpkgs@c51202f) riot-web: 1.6.2 -> 1.6.3 * [`91099c14`](NixOS/nixpkgs@91099c1) riot-desktop: 1.6.2 -> 1.6.3 * [`cda41cf7`](NixOS/nixpkgs@cda41cf) josm: 16239 -> 16538 * [`f26f911a`](NixOS/nixpkgs@f26f911) ksmoothdock: Init at 6.2 stable * [`397a90a6`](NixOS/nixpkgs@397a90a) maintainers: add shamilton * [`4204de06`](NixOS/nixpkgs@4204de0) vimPlugins: update * [`6cc2a43e`](NixOS/nixpkgs@6cc2a43) vimPlugins: resolve github repository redirects * [`a05a858d`](NixOS/nixpkgs@a05a858) vimPlugins.vim-hocon: init at 2017-09-08 * [`98238a01`](NixOS/nixpkgs@98238a0) vimPlugins.vim-spirv: init at 2019-11-20 * [`db21ea28`](NixOS/nixpkgs@db21ea2) vimPlugins.vim-hybrid: init at 2016-01-05 * [`50eddf8a`](NixOS/nixpkgs@50eddf8) vimPlugins.vim-tmux-clipboard: init at 2019-04-07 * [`f9b8c148`](NixOS/nixpkgs@f9b8c14) vimPlugins.vim-numbertoggle: init at 2017-10-26 * [`568d540b`](NixOS/nixpkgs@568d540) vimPlugins.is-vim: init at 2017-10-30 * [`f37b4a8d`](NixOS/nixpkgs@f37b4a8) vimPlugins.vim-mundo: init at 2020-05-06 * [`c9db9df0`](NixOS/nixpkgs@c9db9df) python3Packages.azure-mgmt-batch: 8.0.0 -> 9.0.0 * [`5bc75d72`](NixOS/nixpkgs@5bc75d7) python3Packages.azure-mgmt-hanaonazure: 0.13.0 -> 0.14.0 * [`91c5a18b`](NixOS/nixpkgs@91c5a18) python3Packages.azure-mgmt-imagebuilder: 0.3.0 -> 0.4.0 * [`13818375`](NixOS/nixpkgs@1381837) python3Packages.azure-mgmt-loganalytics: 0.5.0 -> 0.6.0 * [`cd4852a2`](NixOS/nixpkgs@cd4852a) python3Packages.azure-mgmt-signalr: 0.3.0 -> 0.4.0 * [`05f42b2a`](NixOS/nixpkgs@05f42b2) python3Packages.azure-servicebus: 0.50.2 -> 0.50.3 * [`eb036311`](NixOS/nixpkgs@eb03631) azure-cli: 2.5.1 -> 2.7.0 * [`21c43f6e`](NixOS/nixpkgs@21c43f6) python3Packages.azure-servicebus: add imports check * [`3f529586`](NixOS/nixpkgs@3f52958) python3Packages.uamqp: 1.2.7 -> 1.2.8 * [`38f5fce4`](NixOS/nixpkgs@38f5fce) linuxPackages.rtl88x2bu: init at 2020-05-19 * [`86990d60`](NixOS/nixpkgs@86990d6) pythonPackages.wtforms: 2.1 -> 2.3.1 * [`dfd6f3de`](NixOS/nixpkgs@dfd6f3d) liferea: Format with nixpkgs-fmt * [`d67e2a27`](NixOS/nixpkgs@d67e2a2) liferea: Update dependencies * [`f71d9240`](NixOS/nixpkgs@f71d924) buildbot: 2.7.0 -> 2.8.0 * [`87dc127c`](NixOS/nixpkgs@87dc127) openttd: 1.10.1 -> 1.10.2 * [`1fd972bd`](NixOS/nixpkgs@1fd972b) nixos/buildbot-master: fix typo in services.buildbot-master.bpPort * [`4eaa5a08`](NixOS/nixpkgs@4eaa5a0) freecad: use wrapQtAppsHook * [`fb6c3cee`](NixOS/nixpkgs@fb6c3ce) Add {pkgsMusl,pkgsStatic}.stdenv to build on hydra (NixOS/nixpkgs#89425) * [`c9057b37`](NixOS/nixpkgs@c9057b3) ocamlPackages.custom_printf: remove at 112.24.00 * [`073d2fc4`](NixOS/nixpkgs@073d2fc) cgmanager: remove * [`f0396574`](NixOS/nixpkgs@f039657) buildRustPackage: add documentation on how to create cargo.lock patches * [`a4ed97da`](NixOS/nixpkgs@a4ed97d) pythonmagick -> python2.pkgs.pythonmagick * [`0f2d9bbd`](NixOS/nixpkgs@0f2d9bb) atlassian-confluence: 7.5.0 -> 7.5.1 * [`f16f0c2f`](NixOS/nixpkgs@f16f0c2) xdg-desktop-portal-wlr: init at 0.1.0 (NixOS/nixpkgs#83485)
dependencies updates. ## Changelog for nixpkgs: Commits: [NixOS/nixpkgs@f7036e2c...dcb64ea4](NixOS/nixpkgs@f7036e2...dcb64ea) * [`5262ada4`](NixOS/nixpkgs@5262ada) palemoon: 28.9.1 -> 28.9.3 * [`5a94a29e`](NixOS/nixpkgs@5a94a29) mpd: use pkg-config instead of pkgconfig * [`ecdbbdf1`](NixOS/nixpkgs@ecdbbdf) mpd: format inputs * [`69aa4f37`](NixOS/nixpkgs@69aa4f3) mpd: enable tests * [`08bdd8bc`](NixOS/nixpkgs@08bdd8b) mpd: Build and install docs and split outputs * [`f3352f32`](NixOS/nixpkgs@f3352f3) maintainers: add lunik1 * [`a46d7f2d`](NixOS/nixpkgs@a46d7f2) openorienteering-mapper: 0.9.2 -> 0.9.3 * [`4eb8f4ec`](NixOS/nixpkgs@4eb8f4e) aflplusplus: 2.64c -> 2.65c * [`5f19ec3b`](NixOS/nixpkgs@5f19ec3) aflplusplus: don't run unit tests with cmocka * [`d478d7a6`](NixOS/nixpkgs@d478d7a) aflplusplus: remove clang_9 and llvm_9 specificity * [`067a26a4`](NixOS/nixpkgs@067a26a) easyrpg-player: 0.6.1 -> 0.6.2 * [`b7eec6ad`](NixOS/nixpkgs@b7eec6a) wownero: 0.7.0 -> 0.8.0.0 * [`b7a8c4d8`](NixOS/nixpkgs@b7a8c4d) bazel-watcher: 0.13.0 -> 0.13.1 * [`ed73bb8d`](NixOS/nixpkgs@ed73bb8) freerdp: 2.1.0 -> 2.1.1 * [`009284cd`](NixOS/nixpkgs@009284c) displaycal: 3.5 -> 3.8.9.3 * [`7fc97cf3`](NixOS/nixpkgs@7fc97cf) idris2: 0.2.0-840e020 -> 0.2.0 * [`e0c0c1f0`](NixOS/nixpkgs@e0c0c1f) bitwig-studio3: 3.1.2 -> 3.1.3 * [`3704ed17`](NixOS/nixpkgs@3704ed1) vscode-utils: remove extra whitespace * [`0717848d`](NixOS/nixpkgs@0717848) vscode-with-extensions: fix extension directory * [`c906c45f`](NixOS/nixpkgs@c906c45) gazebo, sdformat: remove * [`a410beaa`](NixOS/nixpkgs@a410bea) ignition-transport: remove * [`f9622e30`](NixOS/nixpkgs@f9622e3) ignition-math: remove * [`3b26ba8b`](NixOS/nixpkgs@3b26ba8) maintainers: remove pxc * [`4f99c572`](NixOS/nixpkgs@4f99c57) vscode-extensions.vscode-utils: reapply some changes from bb24faf * [`094bd40d`](NixOS/nixpkgs@094bd40) plex: 1.19.2.2737-b69929dab -> 1.19.3.2852-219a9974e * [`557a4df3`](NixOS/nixpkgs@557a4df) tachyon: install header files * [`f7651f70`](NixOS/nixpkgs@f7651f7) skaffold: 1.9.1 -> 1.10.1 * [`0332c063`](NixOS/nixpkgs@0332c06) coz: fix python shebang * [`07d3ca81`](NixOS/nixpkgs@07d3ca8) sane-airscan: 0.99.0 -> 0.99.3 * [`c7eb16ce`](NixOS/nixpkgs@c7eb16c) qemu: wrap GTK binaries * [`5db5b25c`](NixOS/nixpkgs@5db5b25) php.extensions: Apply patches from the php source root by default * [`2e0d4a8b`](NixOS/nixpkgs@2e0d4a8) php.extensions.mysqlnd: Fix compression support * [`654d1ca4`](NixOS/nixpkgs@654d1ca) olive-editor: use wrapQtAppsHook * [`6031391c`](NixOS/nixpkgs@6031391) maintainers: add seb314 * [`24227ad1`](NixOS/nixpkgs@24227ad) jamulus: init at 3.5.5 * [`da540dbb`](NixOS/nixpkgs@da540db) libreoffce-qt: init at 6.4.3.2 * [`cd712e62`](NixOS/nixpkgs@cd712e6) bazel-buildtools: 2.2.1 -> 3.2.0 * [`6d651f2b`](NixOS/nixpkgs@6d651f2) rubberband: 1.8.1 -> 1.8.2 * [`056089e7`](NixOS/nixpkgs@056089e) syncthing: 1.5.0 -> 1.6.1 * [`04094d7d`](NixOS/nixpkgs@04094d7) mint-x-icons: init at 1.5.5 * [`0de586eb`](NixOS/nixpkgs@0de586e) factorio{,-headless}-experimental: 0.18.26 -> 0.18.29 * [`e5d33f6d`](NixOS/nixpkgs@e5d33f6) fdkaac: init at 1.0.0 * [`f1bf95f8`](NixOS/nixpkgs@f1bf95f) grafana: 7.0.2 -> 7.0.3 * [`3b343be7`](NixOS/nixpkgs@3b343be) wasabiwallet: 1.1.9.2 -> 1.1.11.1 * [`bf1c120e`](NixOS/nixpkgs@bf1c120) python3Packages.cookiecutter: add missing slugify dependency * [`7f87a170`](NixOS/nixpkgs@7f87a17) thunderbird-bin: 68.8.1 -> 68.9.0 * [`5967e4d8`](NixOS/nixpkgs@5967e4d) thunderbird: 68.8.1 -> 68.9.0 * [`8da7b450`](NixOS/nixpkgs@8da7b45) owslib: add pyyaml as a runtime dep * [`2d38b582`](NixOS/nixpkgs@2d38b58) watchexec: 1.12.0 -> 1.13.0 * [`cc1f954b`](NixOS/nixpkgs@cc1f954) ocamlPackages.elpi: 1.10.2 -> 1.11.0 * [`fc255531`](NixOS/nixpkgs@fc25553) slirp4netns: 1.0.1 -> 1.1.0 * [`7384e9b2`](NixOS/nixpkgs@7384e9b) goldendict: 2020-01-09 -> 2020-05-27 * [`8f9e4bef`](NixOS/nixpkgs@8f9e4be) Bump minver.nix to 2.2 * [`bbfc4732`](NixOS/nixpkgs@bbfc473) Don't enable nix-bash-completions when using Nix 2.4 * [`79454f15`](NixOS/nixpkgs@79454f1) gitlab: 12.10.8 -> 13.0.3 * [`0b5c5345`](NixOS/nixpkgs@0b5c534) gitlab: 13.0.3 -> 13.0.4 * [`d8040e24`](NixOS/nixpkgs@d8040e2) overmind: 2.0.3 -> 2.1.1 * [`2379e361`](NixOS/nixpkgs@2379e36) python39: fix build on macOS * [`c51202ff`](NixOS/nixpkgs@c51202f) riot-web: 1.6.2 -> 1.6.3 * [`91099c14`](NixOS/nixpkgs@91099c1) riot-desktop: 1.6.2 -> 1.6.3 * [`cda41cf7`](NixOS/nixpkgs@cda41cf) josm: 16239 -> 16538 * [`f26f911a`](NixOS/nixpkgs@f26f911) ksmoothdock: Init at 6.2 stable * [`397a90a6`](NixOS/nixpkgs@397a90a) maintainers: add shamilton * [`4204de06`](NixOS/nixpkgs@4204de0) vimPlugins: update * [`6cc2a43e`](NixOS/nixpkgs@6cc2a43) vimPlugins: resolve github repository redirects * [`a05a858d`](NixOS/nixpkgs@a05a858) vimPlugins.vim-hocon: init at 2017-09-08 * [`98238a01`](NixOS/nixpkgs@98238a0) vimPlugins.vim-spirv: init at 2019-11-20 * [`db21ea28`](NixOS/nixpkgs@db21ea2) vimPlugins.vim-hybrid: init at 2016-01-05 * [`50eddf8a`](NixOS/nixpkgs@50eddf8) vimPlugins.vim-tmux-clipboard: init at 2019-04-07 * [`f9b8c148`](NixOS/nixpkgs@f9b8c14) vimPlugins.vim-numbertoggle: init at 2017-10-26 * [`568d540b`](NixOS/nixpkgs@568d540) vimPlugins.is-vim: init at 2017-10-30 * [`f37b4a8d`](NixOS/nixpkgs@f37b4a8) vimPlugins.vim-mundo: init at 2020-05-06 * [`c9db9df0`](NixOS/nixpkgs@c9db9df) python3Packages.azure-mgmt-batch: 8.0.0 -> 9.0.0 * [`5bc75d72`](NixOS/nixpkgs@5bc75d7) python3Packages.azure-mgmt-hanaonazure: 0.13.0 -> 0.14.0 * [`91c5a18b`](NixOS/nixpkgs@91c5a18) python3Packages.azure-mgmt-imagebuilder: 0.3.0 -> 0.4.0 * [`13818375`](NixOS/nixpkgs@1381837) python3Packages.azure-mgmt-loganalytics: 0.5.0 -> 0.6.0 * [`cd4852a2`](NixOS/nixpkgs@cd4852a) python3Packages.azure-mgmt-signalr: 0.3.0 -> 0.4.0 * [`05f42b2a`](NixOS/nixpkgs@05f42b2) python3Packages.azure-servicebus: 0.50.2 -> 0.50.3 * [`eb036311`](NixOS/nixpkgs@eb03631) azure-cli: 2.5.1 -> 2.7.0 * [`21c43f6e`](NixOS/nixpkgs@21c43f6) python3Packages.azure-servicebus: add imports check * [`3f529586`](NixOS/nixpkgs@3f52958) python3Packages.uamqp: 1.2.7 -> 1.2.8 * [`38f5fce4`](NixOS/nixpkgs@38f5fce) linuxPackages.rtl88x2bu: init at 2020-05-19 * [`86990d60`](NixOS/nixpkgs@86990d6) pythonPackages.wtforms: 2.1 -> 2.3.1 * [`dfd6f3de`](NixOS/nixpkgs@dfd6f3d) liferea: Format with nixpkgs-fmt * [`d67e2a27`](NixOS/nixpkgs@d67e2a2) liferea: Update dependencies * [`f71d9240`](NixOS/nixpkgs@f71d924) buildbot: 2.7.0 -> 2.8.0 * [`87dc127c`](NixOS/nixpkgs@87dc127) openttd: 1.10.1 -> 1.10.2 * [`1fd972bd`](NixOS/nixpkgs@1fd972b) nixos/buildbot-master: fix typo in services.buildbot-master.bpPort * [`4eaa5a08`](NixOS/nixpkgs@4eaa5a0) freecad: use wrapQtAppsHook * [`fb6c3cee`](NixOS/nixpkgs@fb6c3ce) Add {pkgsMusl,pkgsStatic}.stdenv to build on hydra (NixOS/nixpkgs#89425) * [`c9057b37`](NixOS/nixpkgs@c9057b3) ocamlPackages.custom_printf: remove at 112.24.00 * [`073d2fc4`](NixOS/nixpkgs@073d2fc) cgmanager: remove * [`f0396574`](NixOS/nixpkgs@f039657) buildRustPackage: add documentation on how to create cargo.lock patches * [`a4ed97da`](NixOS/nixpkgs@a4ed97d) pythonmagick -> python2.pkgs.pythonmagick * [`0f2d9bbd`](NixOS/nixpkgs@0f2d9bb) atlassian-confluence: 7.5.0 -> 7.5.1 * [`f16f0c2f`](NixOS/nixpkgs@f16f0c2) xdg-desktop-portal-wlr: init at 0.1.0 (NixOS/nixpkgs#83485) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dependencies updates. ## Changelog for nixpkgs: Commits: [NixOS/nixpkgs@f7036e2c...dcb64ea4](NixOS/nixpkgs@f7036e2...dcb64ea) * [`5262ada4`](NixOS/nixpkgs@5262ada) palemoon: 28.9.1 -> 28.9.3 * [`5a94a29e`](NixOS/nixpkgs@5a94a29) mpd: use pkg-config instead of pkgconfig * [`ecdbbdf1`](NixOS/nixpkgs@ecdbbdf) mpd: format inputs * [`69aa4f37`](NixOS/nixpkgs@69aa4f3) mpd: enable tests * [`08bdd8bc`](NixOS/nixpkgs@08bdd8b) mpd: Build and install docs and split outputs * [`f3352f32`](NixOS/nixpkgs@f3352f3) maintainers: add lunik1 * [`a46d7f2d`](NixOS/nixpkgs@a46d7f2) openorienteering-mapper: 0.9.2 -> 0.9.3 * [`4eb8f4ec`](NixOS/nixpkgs@4eb8f4e) aflplusplus: 2.64c -> 2.65c * [`5f19ec3b`](NixOS/nixpkgs@5f19ec3) aflplusplus: don't run unit tests with cmocka * [`d478d7a6`](NixOS/nixpkgs@d478d7a) aflplusplus: remove clang_9 and llvm_9 specificity * [`067a26a4`](NixOS/nixpkgs@067a26a) easyrpg-player: 0.6.1 -> 0.6.2 * [`b7eec6ad`](NixOS/nixpkgs@b7eec6a) wownero: 0.7.0 -> 0.8.0.0 * [`b7a8c4d8`](NixOS/nixpkgs@b7a8c4d) bazel-watcher: 0.13.0 -> 0.13.1 * [`ed73bb8d`](NixOS/nixpkgs@ed73bb8) freerdp: 2.1.0 -> 2.1.1 * [`009284cd`](NixOS/nixpkgs@009284c) displaycal: 3.5 -> 3.8.9.3 * [`7fc97cf3`](NixOS/nixpkgs@7fc97cf) idris2: 0.2.0-840e020 -> 0.2.0 * [`e0c0c1f0`](NixOS/nixpkgs@e0c0c1f) bitwig-studio3: 3.1.2 -> 3.1.3 * [`3704ed17`](NixOS/nixpkgs@3704ed1) vscode-utils: remove extra whitespace * [`0717848d`](NixOS/nixpkgs@0717848) vscode-with-extensions: fix extension directory * [`c906c45f`](NixOS/nixpkgs@c906c45) gazebo, sdformat: remove * [`a410beaa`](NixOS/nixpkgs@a410bea) ignition-transport: remove * [`f9622e30`](NixOS/nixpkgs@f9622e3) ignition-math: remove * [`3b26ba8b`](NixOS/nixpkgs@3b26ba8) maintainers: remove pxc * [`4f99c572`](NixOS/nixpkgs@4f99c57) vscode-extensions.vscode-utils: reapply some changes from bb24faf * [`094bd40d`](NixOS/nixpkgs@094bd40) plex: 1.19.2.2737-b69929dab -> 1.19.3.2852-219a9974e * [`557a4df3`](NixOS/nixpkgs@557a4df) tachyon: install header files * [`f7651f70`](NixOS/nixpkgs@f7651f7) skaffold: 1.9.1 -> 1.10.1 * [`0332c063`](NixOS/nixpkgs@0332c06) coz: fix python shebang * [`07d3ca81`](NixOS/nixpkgs@07d3ca8) sane-airscan: 0.99.0 -> 0.99.3 * [`c7eb16ce`](NixOS/nixpkgs@c7eb16c) qemu: wrap GTK binaries * [`5db5b25c`](NixOS/nixpkgs@5db5b25) php.extensions: Apply patches from the php source root by default * [`2e0d4a8b`](NixOS/nixpkgs@2e0d4a8) php.extensions.mysqlnd: Fix compression support * [`654d1ca4`](NixOS/nixpkgs@654d1ca) olive-editor: use wrapQtAppsHook * [`6031391c`](NixOS/nixpkgs@6031391) maintainers: add seb314 * [`24227ad1`](NixOS/nixpkgs@24227ad) jamulus: init at 3.5.5 * [`da540dbb`](NixOS/nixpkgs@da540db) libreoffce-qt: init at 6.4.3.2 * [`cd712e62`](NixOS/nixpkgs@cd712e6) bazel-buildtools: 2.2.1 -> 3.2.0 * [`6d651f2b`](NixOS/nixpkgs@6d651f2) rubberband: 1.8.1 -> 1.8.2 * [`056089e7`](NixOS/nixpkgs@056089e) syncthing: 1.5.0 -> 1.6.1 * [`04094d7d`](NixOS/nixpkgs@04094d7) mint-x-icons: init at 1.5.5 * [`0de586eb`](NixOS/nixpkgs@0de586e) factorio{,-headless}-experimental: 0.18.26 -> 0.18.29 * [`e5d33f6d`](NixOS/nixpkgs@e5d33f6) fdkaac: init at 1.0.0 * [`f1bf95f8`](NixOS/nixpkgs@f1bf95f) grafana: 7.0.2 -> 7.0.3 * [`3b343be7`](NixOS/nixpkgs@3b343be) wasabiwallet: 1.1.9.2 -> 1.1.11.1 * [`bf1c120e`](NixOS/nixpkgs@bf1c120) python3Packages.cookiecutter: add missing slugify dependency * [`7f87a170`](NixOS/nixpkgs@7f87a17) thunderbird-bin: 68.8.1 -> 68.9.0 * [`5967e4d8`](NixOS/nixpkgs@5967e4d) thunderbird: 68.8.1 -> 68.9.0 * [`8da7b450`](NixOS/nixpkgs@8da7b45) owslib: add pyyaml as a runtime dep * [`2d38b582`](NixOS/nixpkgs@2d38b58) watchexec: 1.12.0 -> 1.13.0 * [`cc1f954b`](NixOS/nixpkgs@cc1f954) ocamlPackages.elpi: 1.10.2 -> 1.11.0 * [`fc255531`](NixOS/nixpkgs@fc25553) slirp4netns: 1.0.1 -> 1.1.0 * [`7384e9b2`](NixOS/nixpkgs@7384e9b) goldendict: 2020-01-09 -> 2020-05-27 * [`8f9e4bef`](NixOS/nixpkgs@8f9e4be) Bump minver.nix to 2.2 * [`bbfc4732`](NixOS/nixpkgs@bbfc473) Don't enable nix-bash-completions when using Nix 2.4 * [`79454f15`](NixOS/nixpkgs@79454f1) gitlab: 12.10.8 -> 13.0.3 * [`0b5c5345`](NixOS/nixpkgs@0b5c534) gitlab: 13.0.3 -> 13.0.4 * [`d8040e24`](NixOS/nixpkgs@d8040e2) overmind: 2.0.3 -> 2.1.1 * [`2379e361`](NixOS/nixpkgs@2379e36) python39: fix build on macOS * [`c51202ff`](NixOS/nixpkgs@c51202f) riot-web: 1.6.2 -> 1.6.3 * [`91099c14`](NixOS/nixpkgs@91099c1) riot-desktop: 1.6.2 -> 1.6.3 * [`cda41cf7`](NixOS/nixpkgs@cda41cf) josm: 16239 -> 16538 * [`f26f911a`](NixOS/nixpkgs@f26f911) ksmoothdock: Init at 6.2 stable * [`397a90a6`](NixOS/nixpkgs@397a90a) maintainers: add shamilton * [`4204de06`](NixOS/nixpkgs@4204de0) vimPlugins: update * [`6cc2a43e`](NixOS/nixpkgs@6cc2a43) vimPlugins: resolve github repository redirects * [`a05a858d`](NixOS/nixpkgs@a05a858) vimPlugins.vim-hocon: init at 2017-09-08 * [`98238a01`](NixOS/nixpkgs@98238a0) vimPlugins.vim-spirv: init at 2019-11-20 * [`db21ea28`](NixOS/nixpkgs@db21ea2) vimPlugins.vim-hybrid: init at 2016-01-05 * [`50eddf8a`](NixOS/nixpkgs@50eddf8) vimPlugins.vim-tmux-clipboard: init at 2019-04-07 * [`f9b8c148`](NixOS/nixpkgs@f9b8c14) vimPlugins.vim-numbertoggle: init at 2017-10-26 * [`568d540b`](NixOS/nixpkgs@568d540) vimPlugins.is-vim: init at 2017-10-30 * [`f37b4a8d`](NixOS/nixpkgs@f37b4a8) vimPlugins.vim-mundo: init at 2020-05-06 * [`c9db9df0`](NixOS/nixpkgs@c9db9df) python3Packages.azure-mgmt-batch: 8.0.0 -> 9.0.0 * [`5bc75d72`](NixOS/nixpkgs@5bc75d7) python3Packages.azure-mgmt-hanaonazure: 0.13.0 -> 0.14.0 * [`91c5a18b`](NixOS/nixpkgs@91c5a18) python3Packages.azure-mgmt-imagebuilder: 0.3.0 -> 0.4.0 * [`13818375`](NixOS/nixpkgs@1381837) python3Packages.azure-mgmt-loganalytics: 0.5.0 -> 0.6.0 * [`cd4852a2`](NixOS/nixpkgs@cd4852a) python3Packages.azure-mgmt-signalr: 0.3.0 -> 0.4.0 * [`05f42b2a`](NixOS/nixpkgs@05f42b2) python3Packages.azure-servicebus: 0.50.2 -> 0.50.3 * [`eb036311`](NixOS/nixpkgs@eb03631) azure-cli: 2.5.1 -> 2.7.0 * [`21c43f6e`](NixOS/nixpkgs@21c43f6) python3Packages.azure-servicebus: add imports check * [`3f529586`](NixOS/nixpkgs@3f52958) python3Packages.uamqp: 1.2.7 -> 1.2.8 * [`38f5fce4`](NixOS/nixpkgs@38f5fce) linuxPackages.rtl88x2bu: init at 2020-05-19 * [`86990d60`](NixOS/nixpkgs@86990d6) pythonPackages.wtforms: 2.1 -> 2.3.1 * [`dfd6f3de`](NixOS/nixpkgs@dfd6f3d) liferea: Format with nixpkgs-fmt * [`d67e2a27`](NixOS/nixpkgs@d67e2a2) liferea: Update dependencies * [`f71d9240`](NixOS/nixpkgs@f71d924) buildbot: 2.7.0 -> 2.8.0 * [`87dc127c`](NixOS/nixpkgs@87dc127) openttd: 1.10.1 -> 1.10.2 * [`1fd972bd`](NixOS/nixpkgs@1fd972b) nixos/buildbot-master: fix typo in services.buildbot-master.bpPort * [`4eaa5a08`](NixOS/nixpkgs@4eaa5a0) freecad: use wrapQtAppsHook * [`fb6c3cee`](NixOS/nixpkgs@fb6c3ce) Add {pkgsMusl,pkgsStatic}.stdenv to build on hydra (NixOS/nixpkgs#89425) * [`c9057b37`](NixOS/nixpkgs@c9057b3) ocamlPackages.custom_printf: remove at 112.24.00 * [`073d2fc4`](NixOS/nixpkgs@073d2fc) cgmanager: remove * [`f0396574`](NixOS/nixpkgs@f039657) buildRustPackage: add documentation on how to create cargo.lock patches * [`a4ed97da`](NixOS/nixpkgs@a4ed97d) pythonmagick -> python2.pkgs.pythonmagick * [`0f2d9bbd`](NixOS/nixpkgs@0f2d9bb) atlassian-confluence: 7.5.0 -> 7.5.1 * [`f16f0c2f`](NixOS/nixpkgs@f16f0c2) xdg-desktop-portal-wlr: init at 0.1.0 (NixOS/nixpkgs#83485) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
}; | ||
|
||
nativeBuildInputs = [ meson ninja pkgconfig wayland-protocols ]; | ||
buildInputs = [ pipewire wayland elogind systemd libdrm ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
elogind
is an alternative to libsystemd
if the distribution doesn't use systemd, I don't think this dependency is used here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, good catch! You can even see it here, I'll try to keep that in mind in my next PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That begs the question: is nix on non-systemd Linux distributions supported? Should with have an argument withSystemd ? true
so that you can use it outside of NixOS and systemd distros?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is nix on non-systemd Linux distributions supported?
Nix is used by people on other distros that don't have systems. For example with home-manager. So it can be a consideration to have. If it's too much work I wouldn't hold the package back just for that. People on other systems are probably more likely to install xdg-desktop-portal-wlr using their system package manager instead.
Motivation for this change
In this tiring times, more and more people are using conference calls, some of them being in Sway (me included). It was a sad day when I realised a had to change environments to share my screen. This is an attempt to solve the issue.
By enabling the
pipewire
service, enablingxdg.portal
, and adding this package to thexdg.portal.extraPortals
, some applications (including Firefox ifgtkUsePortal
is true), should be able to copy the screen.Notes:
I didn't want to rebuild my PC config using the staging branch so I tried to build a VM using the following minimal config, but Firefox was so slow I couldn't test anything :-/
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)