Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dgraph: 1.0.17 -> 20.03.3 #89642

Merged
merged 1 commit into from Jun 9, 2020
Merged

dgraph: 1.0.17 -> 20.03.3 #89642

merged 1 commit into from Jun 9, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jun 6, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from sigma and kalbasit June 6, 2020 12:27
@zowoq zowoq mentioned this pull request Jun 7, 2020
Closed
10 tasks
@RaghavSood
Copy link
Member

I've opened #89719 to move dgraph to v20.03.03, as that is the latest version installed by https://get.dgraph.io, used by the installation instructions in the dgraph docs.

@zowoq
Copy link
Contributor Author

zowoq commented Jun 7, 2020

I can bump this to 20.03, I'd prefer that we keep this as it has other improvements.

@RaghavSood
Copy link
Member

Actually, I would suggest we keep this as 1.2.5, and I can patch over your shell completion fixes and update my PR to add dgraph_20_03 as a separate package - there might be breaking changes from v1->v20, and it makes sense to keep the default at 1.2.5

@zowoq
Copy link
Contributor Author

zowoq commented Jun 7, 2020

Updated to 20.03

@zowoq zowoq changed the title dgraph: 1.0.17 -> 1.2.5 dgraph: 1.0.17 -> 20.03.3 Jun 7, 2020
@zowoq
Copy link
Contributor Author

zowoq commented Jun 7, 2020

Upstream switched to calver after 1.2.2 so I don't think a separate package is needed.

@RaghavSood
Copy link
Member

I think building with make might cause issues with the git revision flags

@zowoq
Copy link
Contributor Author

zowoq commented Jun 7, 2020 •
edited

I think building with make might cause issues with the git revision flags

It seems fine? It does complain that git isn't available during the build but we're using BUILD_VERSION which is passed through to ldflags.

https://github.com/dgraph-io/dgraph/blob/v20.03.3/Makefile
https://github.com/dgraph-io/dgraph/blob/v20.03.3/dgraph/Makefile

@bhipple
Copy link
Contributor

bhipple commented Jun 9, 2020

Result of nixpkgs-review pr 89642 1

1 package built:
- dgraph

@bhipple bhipple merged commit 1830fde into NixOS:master Jun 9, 2020
@zowoq zowoq deleted the dgraph branch June 9, 2020 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigma sigma sigma approved these changes

@bhipple bhipple bhipple approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zowoq @RaghavSood @bhipple @sigma