Add another https port, 8444 #24016
Merged
Add another https port, 8444 #24016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmcgruer
force-pushed
the
smcgruer/another_https_port
branch
from
44d8ce8
to
419d316
Compare
This is required to test origin isolation (https://github.com/WICG/origin-isolation), which includes guarantees that two origins with the same host but different ports are treated as isolated. Fixes #23579
stephenmcgruer
force-pushed
the
smcgruer/another_https_port
branch
from
419d316
to
03c6936
Compare
wpt-pr-bot
added
assets
infra
serve
wptrunner
wpt-pr-bot
requested review from
deniak,
Hexcles,
jgraham,
LukeZielinski and
zqzhang
|
I choose 8444 entirely arbitrarily. The Taskcluster failures are from stability checks timing out. The wpt.fyi browser results are just flake, I think. The Azure Pipeline failures seem a mixture of things... none obviously related to this PR. |
|
Ping @LukeZielinski are you able to review? |
LukeZielinski
approved these changes
Jun 22, 2020
jgraham
approved these changes
Jun 22, 2020
stephenmcgruer
changed the title
stephenmcgruer
added a commit
that referenced
this pull request
Jun 30, 2020
This reverts commit 95cdf1f. Adding another HTTPS port broke both wpt.live (as its config no longer matched the number of ports asserted in wptserve) and the Chromium WPT Importer (as our pinned tooling failed to sub common/get-host-info.sub.js due to indexing out of bounds).
stephenmcgruer
added a commit
that referenced
this pull request
Jun 30, 2020
This reverts the change to common/get-host-info.sub.js in commit 95cdf1f. Adding another HTTPS port broke there broke the Chromium WPT Importer (as the pinned tooling failed to sub common/get-host-info.sub.js due to indexing out of bounds).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to test origin isolation
(https://github.com/WICG/origin-isolation), which includes guarantees
that two origins with the same host but different ports are treated as
isolated.
Fixes #23579