Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libreoffice: explicitly disable unsupported GTK2 #89529

Merged
merged 2 commits into from Jun 6, 2020
Merged

libreoffice: explicitly disable unsupported GTK2 #89529

merged 2 commits into from Jun 6, 2020

Conversation

peterhoeg
Copy link
Member

Motivation for this change

libreoffice-still will still try to build support for GTK2 (even if not
present) and fail now that we no longer provide gtk2 as an input.

Fixes #89524

Still building here, so I haven't had the chance to actually execute it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member Author

@GrahamcOfBorg build libreoffice-still libreoffice-fresh libreoffice-qt

@ofborg ofborg bot requested a review from 7c6f434c June 5, 2020 09:32
@peterhoeg
Copy link
Member Author

@GrahamcOfBorg build libreoffice-still libreoffice-fresh libreoffice-qt

@peterhoeg peterhoeg merged commit dfbc6b3 into NixOS:master Jun 6, 2020
@peterhoeg peterhoeg deleted the fix_lo_gtk branch June 6, 2020 00:48
@peterhoeg peterhoeg restored the fix_lo_gtk branch October 6, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libreoffice build failure on master
1 participant
@peterhoeg