Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: 1.43.0 -> 1.44.1 #89576

Merged
merged 2 commits into from Jul 2, 2020
Merged

rustc: 1.43.0 -> 1.44.1 #89576

merged 2 commits into from Jul 2, 2020

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Jun 6, 2020

I wasn’t able to build thunderbird and Firefox for unrelated reasons (unless it’s gone away on a more recent staging I’ll open a PR for that shortly), but with those issues addressed I’ve successfully built Firefox and Thunderbird with Rust 1.44, so they shouldn’t block the rust update.

Could a Darwin user please nix-build -A fd for me please?

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais alyssais requested review from LnL7 and Mic92 as code owners June 6, 2020 01:09
LnL7
LnL7 reviewed Jun 7, 2020
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many other things failed on staging so can't test it properly as is.

@Mic92
Copy link
Member

Mic92 commented Jun 8, 2020

cannot test any cargo-based build on aarch64 because one git test fail on our community aarch64 builder. rustc builds itself.

@Ma27 Ma27 mentioned this pull request Jun 11, 2020
Closed
@FRidh FRidh added this to WIP in Staging via automation Jun 13, 2020
@FRidh FRidh moved this from WIP to Needs review in Staging Jun 13, 2020
@FRidh FRidh added this to the 20.09 milestone Jun 19, 2020
@FRidh
Copy link
Member

FRidh commented Jun 19, 2020

Reminder for testing this PR.

Ma27
Ma27 approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this while investigating #89481, LGTM 👍

Staging automation moved this from Needs review to Ready Jun 19, 2020
@Mic92
Copy link
Member

Mic92 commented Jun 21, 2020

I will give aarch64 another try.

@Mic92
Copy link
Member

Mic92 commented Jun 22, 2020 •
edited

aarch64 builds now fd properly.

@marsam marsam mentioned this pull request Jun 23, 2020
Closed
10 tasks
@L-as
Copy link
Member

L-as commented Jun 27, 2020

This should be updated to 1.44.1 IMO. Apparently 1.44.0 had several regressions: https://github.com/rust-lang/rust/blob/stable/RELEASES.md#version-1441-2020-06-18

@alyssais
rustc: 1.43.0 -> 1.44.1
21db556
@alyssais
rust_1_42: drop
05182c7 
Nothing seems to need this to build any more.
@alyssais
Copy link
Member Author

alyssais commented Jun 30, 2020 via email

@FRidh FRidh changed the title rustc: 1.43.0 -> 1.44.0 rustc: 1.43.0 -> 1.44.1 Jul 2, 2020
@FRidh FRidh merged commit 204d583 into NixOS:staging Jul 2, 2020
Staging automation moved this from Ready to Done Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 left review comments

@lblasc lblasc lblasc approved these changes

@Ma27 Ma27 Ma27 approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
Staging
  
Done
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@alyssais @Mic92 @FRidh @L-as @lblasc @LnL7 @Ma27