Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote allowUnfreePredicate in remediation message #89564

Merged
merged 1 commit into from Nov 10, 2020
Merged

Promote allowUnfreePredicate in remediation message #89564

merged 1 commit into from Nov 10, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Jun 5, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@raboof raboof force-pushed the promote-allowUnfreePredicate-in-remediation-message branch from 7084534 to 0eca1a0 Compare June 7, 2020 08:37
@raboof raboof force-pushed the promote-allowUnfreePredicate-in-remediation-message branch from 0eca1a0 to e6db788 Compare June 8, 2020 08:10
@raboof raboof force-pushed the promote-allowUnfreePredicate-in-remediation-message branch 3 times, most recently from 05ed373 to 3f7d019 Compare July 8, 2020 12:29
@raboof
Copy link
Member Author

raboof commented Jul 8, 2020

/marvin opt-in

@marvin-mk2 marvin-mk2 bot added the marvin label Jul 8, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 8, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@raboof raboof requested a review from matthewbauer July 8, 2020 12:55
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/260

@raboof raboof force-pushed the promote-allowUnfreePredicate-in-remediation-message branch from 3f7d019 to f665015 Compare November 9, 2020 16:26
@raboof
Copy link
Member Author

raboof commented Nov 9, 2020

/status needs_reviewer

@marvin-mk2 marvin-mk2 bot requested a review from timokau November 10, 2020 16:30
timokau
timokau approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks!

@timokau timokau merged commit 8854532 into NixOS:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wamserma wamserma wamserma approved these changes

@timokau timokau timokau approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 0 10.rebuild-linux: 0 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@raboof @nixos-discourse @matthewbauer @wamserma @timokau