Skip to content
This repository was archived by the owner on Apr 12, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 42f7db63ff04
Choose a base ref
...
head repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5a8cdcc278ee
Choose a head ref
  • 8 commits
  • 3 files changed
  • 4 contributors

Commits on May 16, 2020

  1. Unverified

    The committer email address is not verified.
    Copy the full SHA
    5a94a29 View commit details
  2. mpd: format inputs

    doronbehar committed May 16, 2020

    Unverified

    The committer email address is not verified.
    Copy the full SHA
    ecdbbdf View commit details
  3. mpd: enable tests

    doronbehar committed May 16, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    69aa4f3 View commit details
  4. Copy the full SHA
    08bdd8b View commit details

Commits on Jun 4, 2020

  1. Copy the full SHA
    7f87a17 View commit details
  2. thunderbird: 68.8.1 -> 68.9.0

    taku0 committed Jun 4, 2020
    Copy the full SHA
    5967e4d View commit details

Commits on Jun 5, 2020

  1. Merge pull request #87949 from doronbehar/mpd-docs

    mpd: enable tests + install docs + split outputs
    marsam authored Jun 5, 2020
    Copy the full SHA
    810f240 View commit details
  2. Copy the full SHA
    5a8cdcc View commit details

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -72,13 +72,13 @@ assert waylandSupport -> gtk3Support == true;

stdenv.mkDerivation rec {
pname = "thunderbird";
version = "68.8.1";
version = "68.9.0";

src = fetchurl {
url =
"mirror://mozilla/thunderbird/releases/${version}/source/thunderbird-${version}.source.tar.xz";
sha512 =
"2zq65qhrg8xsz75yywcijdjbkndn79w73v5vyahiyyibc8lfjphz0zaihk67ja82fpnxlnsfvy45s8x5l42kcbb0wibkjy7m55bd6h7";
"3q0dikgkfr72hhz39pxi2f0cljn09lw4940qcn9kzfwfid2h290j7pihx6gs0z6h82fl78f9fl1598d064lwl1i2434dzx6bg4p4549";
};

nativeBuildInputs = [
60 changes: 55 additions & 5 deletions pkgs/servers/mpd/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ stdenv, fetchFromGitHub, meson, ninja, pkgconfig, glib, systemd, boost, darwin
{ stdenv, fetchFromGitHub, meson, ninja, pkg-config, glib, systemd, boost, darwin
# Inputs
, curl, libmms, libnfs, samba
# Archive support
@@ -19,6 +19,13 @@
# Tag support
, libid3tag
, nixosTests
# For documentation
, doxygen
, python3Packages # for sphinx-build
# For tests
, gtest
, fetchpatch # used to fetch an upstream patch fixing a failing test
, zip
}:

let
@@ -112,17 +119,60 @@ let
sha256 = "0jnhjhm1ilpcwb4f58b8pgyzjq3dlr0j2xyk0zck0afwkdxyj9cb";
};

buildInputs = [ glib boost ]
# Won't be needed when 0.21.24 will be out
patches = [
# Tests fail otherwise, see https://github.com/MusicPlayerDaemon/MPD/issues/844
(fetchpatch {
url = "https://github.com/MusicPlayerDaemon/MPD/commit/7aea2853612743e111ae5e947c8d467049e291a8.patch";
sha256 = "1bmxlsaiz3wlg1yyc4rkwsmgvc0pirv0s1vdxxsn91yssmh16c2g";
excludes = [
# The patch fails otherwise because it tries to update the NEWS
# file which doesn't have the title "ver 0.21.24" yet.
"NEWS"
];
})
];

buildInputs = [
glib
boost
# According to the configurePhase of meson, gtest is considered a
# runtime dependency. Quoting:
#
# Run-time dependency GTest found: YES 1.10.0
gtest
]
++ (lib.concatLists (lib.attrVals features_ featureDependencies))
++ lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.AudioToolbox darwin.apple_sdk.frameworks.AudioUnit ];

nativeBuildInputs = [ meson ninja pkgconfig ];
nativeBuildInputs = [
meson
ninja
pkg-config
python3Packages.sphinx
doxygen
];

# Otherwise, the meson log says:
#
# Program zip found: NO
checkInputs = [ zip ];

doCheck = true;

enableParallelBuilding = true;

mesonAutoFeatures = "disabled";
mesonFlags =
map (x: "-D${x}=enabled") features_

outputs = [ "out" "doc" "man" ];

mesonFlags = [
# Documentation is enabled unconditionally but it's not installed
# unconditionally thanks to the outputs being split
"-Ddocumentation=true"
"-Dtest=true"
]
++ map (x: "-D${x}=enabled") features_
++ map (x: "-D${x}=disabled") (lib.subtractLists features_ knownFeatures)
++ lib.optional (builtins.elem "zeroconf" features_)
"-Dzeroconf=avahi"