Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssmtp: adding debug option #89594

Closed
wants to merge 1 commit into from
Closed

ssmtp: adding debug option #89594

wants to merge 1 commit into from

Conversation

sjau
Copy link

@sjau sjau commented Jun 6, 2020

Motivation for this change

Adding the debug option to the ssmtp module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

aanderse commented Jun 6, 2020

How about we just add a settings option instead so the entire configuration file can be specified/overridden.

@sjau
Copy link
Author

sjau commented Jun 6, 2020

I don't know what that is. Sorry.

@aanderse aanderse mentioned this pull request Jun 6, 2020
Merged
10 tasks
@aanderse
Copy link
Member

aanderse commented Jun 6, 2020

@sjau obviously no need to be sorry! Pardon my vague post, but I have created a PR for you to review now. I hope this suits you well.

@Lassulus
Copy link
Member

so, can this be closed now?

@aanderse
Copy link
Member

Yes. Thanks!

@aanderse aanderse closed this Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sjau @aanderse @Lassulus