Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssb-patchwork: 3.17.7 -> 3.18.0 #89609

Merged
merged 1 commit into from Aug 22, 2020
Merged

ssb-patchwork: 3.17.7 -> 3.18.0 #89609

merged 1 commit into from Aug 22, 2020

Conversation

cyplo
Copy link
Contributor

@cyplo cyplo commented Jun 6, 2020 •
edited

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from picnoir and asymmetric June 6, 2020 08:56
picnoir
picnoir approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member

@picnoir picnoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyplo
Copy link
Contributor Author

cyplo commented Jun 12, 2020

@asymmetric @thedavidmeister - any thoughts on this one ? :)

@asymmetric
Copy link
Contributor

The SSB DB is borked on my machine so can't really test this :(

@cyplo
Copy link
Contributor Author

cyplo commented Jun 12, 2020

@asymmetric - would it make sense to test with a new db, just to see it booting up and getting synced ?

@asymmetric
Copy link
Contributor

asymmetric commented Jun 12, 2020 •
edited

@cyplo if you provide me with instructions, yes :)

(Anyway, I can't merge this so you'd get only marginal benefits by me approving this, since another maintainer already has)

@thedavidmeister
Copy link
Contributor

hey i dropped off sb, maybe take me off maintainer for this one :)

@cyplo
ssb-patchwork: 3.17.7 -> 3.18.0
f67ea88 
removing thedavidmeister as per his request as well
@cyplo
Copy link
Contributor Author

cyplo commented Jun 17, 2020

Removed you and forced pushed the squashed change @thedavidmeister , thanks for all the help :)

@ofborg ofborg bot requested a review from picnoir June 17, 2020 11:20
@Lassulus Lassulus merged commit 7cc4c7a into NixOS:master Aug 22, 2020
@cyplo cyplo deleted the update-ssb-patchwork branch August 23, 2020 11:50
@cyplo cyplo restored the update-ssb-patchwork branch November 14, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asymmetric asymmetric Awaiting requested review from asymmetric

@picnoir picnoir Awaiting requested review from picnoir

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cyplo @asymmetric @thedavidmeister @picnoir @Lassulus