Fix SSurface::EdgeNormalsWithinSurface() to handle non-orthogonal u,v derivatives correctly. #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… derivatives correctly.
|
I've gone back and forth with a number of models and can't find any regressions or improvements with this. I'd like to merge it if that's OK because the math is more correct than without it. |
This was referenced Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to the corrections in #473 but affects calculation of edge normals in boolean.cpp. I don't know a specific issue that this fixes, so I'd like to hold off merging until we have an example issue that it corrects. Such problems are likely to occur with booleans involving Helix extrusions.