Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transmission: add libstdc++ and libgcc_s permissions to apparmor profile #89530

Merged
merged 1 commit into from Jun 10, 2020
Merged

transmission: add libstdc++ and libgcc_s permissions to apparmor profile #89530

merged 1 commit into from Jun 10, 2020

Conversation

DIzFer
Copy link
Contributor

@DIzFer DIzFer commented Jun 5, 2020

Motivation for this change

Transmission's update to 3.0 seems to also have it require access to reading {pkgs.gcc.cc.lib}/lib/libstdc++.so and libgcc_s.so. If running with Apparmor enabled, the service fails to run.

Things done

Added permission for the service to read both libraries in the Apparmor profile.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@DIzFer
Copy link
Contributor Author

DIzFer commented Jun 5, 2020

Additionally, I wonder if it would be interesting to change at least the transmission test to have apparmor enabled, since IIRC this is the second time an update breaks because of missing apparmor profile updates for me.

@DIzFer
Copy link
Contributor Author

DIzFer commented Jun 5, 2020

Indeed, simply adding security.apparmor.enabled makes the test fail. I just opened a different PR for that in #89532

@bjornfor bjornfor merged commit f2d1568 into NixOS:master Jun 10, 2020
@DIzFer DIzFer deleted the transmission-apparmor-fix branch June 12, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DIzFer @bjornfor