Skip to content
This repository has been archived by the owner on Apr 12, 2021. It is now read-only.

No SJLJ on x86_64 #20

Closed
wants to merge 1 commit into from

Conversation

angerman
Copy link
Contributor

@angerman angerman commented Jun 6, 2020

On x86_64 we can perfectly fine use SEH for exceptions, and do no need
to rely on sjlj logic; sjlj needs to be used with dwarf2 only on i686.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

On x86_64 we can perfectly fine use SEH for exceptions, and do no need
to rely on sjlj logic; sjlj needs to be used with dwarf2 only on i686.
@angerman
Copy link
Contributor Author

angerman commented Jun 6, 2020

Upstream is here: NixOS/nixpkgs#89582

@angerman angerman closed this Jun 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant