Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.python-daemon: disable tests after pytest upgrade #89586

Closed
wants to merge 1 commit into from

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Jun 6, 2020

A git bisect shows this stopped building with adb485b.
Many tests appear to need updates.

CC @jonringer

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

A git bisect shows this stopped building with adb485b.
Many tests appear to need updates.
@@ -20,6 +20,10 @@ buildPythonPackage rec {
propagatedBuildInputs = [ docutils lockfile ];

checkInputs = [ pytest mock testscenarios ];

# Test suite is not compatible with pytest > 5.3.5
doCheck = false;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

===== 39 failed, 204 passed, 2 deselected, 2 warnings, 32 errors in 3.43s ======

Possible we could do better here with patching and disabling, maybe?

https://hydra.nixos.org/build/120804609

@FRidh
Copy link
Member

FRidh commented Jun 11, 2020

Using pytest_4 solves the issue 35556ac

@FRidh FRidh closed this Jun 11, 2020
@FRidh
Copy link
Member

FRidh commented Jun 11, 2020

pushed 77d893e to master

@bhipple
Copy link
Contributor Author

bhipple commented Jun 11, 2020

Thanks @FRidh! That is a much nicer fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants