Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkvtoolnix: fix Darwin build #89584

Merged
merged 1 commit into from Jun 6, 2020
Merged

mkvtoolnix: fix Darwin build #89584

merged 1 commit into from Jun 6, 2020

Conversation

bdesham
Copy link
Contributor

@bdesham bdesham commented Jun 6, 2020

Motivation for this change

The build had broken on Darwin with an error about std::optional not being available. Upgrading from -std=c++14 to -std=c++17 fixed it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @codyopel @rnhmjoj

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 6, 2020
@ofborg ofborg bot requested review from rnhmjoj and codyopel June 6, 2020 03:02
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jun 6, 2020

@GrahamcOfBorg build mkvtoolnix

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jun 6, 2020

@GrahamcOfBorg build mkvtoolnix-cli

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jun 6, 2020

@GrahamcOfBorg build mkvtoolnix-cli

@bdesham bdesham mentioned this pull request Jun 6, 2020
Closed
10 tasks
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jun 6, 2020

I can't test on darwin and ofBorg is timing out so I'm going to trust you.

@rnhmjoj rnhmjoj merged commit c5acf27 into NixOS:master Jun 6, 2020
@bdesham bdesham deleted the fix-mkvtoolnix-on-darwin branch August 17, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj Awaiting requested review from rnhmjoj

@codyopel codyopel Awaiting requested review from codyopel

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bdesham @rnhmjoj