Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #614: restart queue/evaluator on sufficient disk space avai… #777

Merged
merged 3 commits into from Jul 27, 2020

Conversation

kquick
Copy link
Contributor

@kquick kquick commented Jun 5, 2020

…lable.

hydra-module.nix Outdated
Comment on lines 406 to 407
spacestopstart() { # $1 = job, $2 = min GB free
if [ $spaceleft -lt $(($2 * 1024**3)) ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give useful names to $1 and $2 in the function? Also, can you print a message in the "starting" block?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, @grahamc .

@grahamc grahamc merged commit 3e73a2f into NixOS:master Jul 27, 2020
@grahamc
Copy link
Member

grahamc commented Jul 27, 2020

Thank you!

@kquick
Copy link
Contributor Author

kquick commented Jul 27, 2020

Thanks for the merge, @grahamc. You might want to close issue 614 now.

@kquick kquick deleted the fix614 branch July 27, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants