could you not update the lua packages version ? (but just change the url so that it uses mirrors instead). I am afraid this would break other things.
As for the pulseaudio one, I wanted to move it to generated too see #78565 but didn't have the time: you would need to remove it from lua-packages.nix too cc @doronbehar

@teto I've checked this pull request with: nix-shell -p nixpkgs-review --run "nixpkgs-review pr 89632" all dependencies should build fine (at least on x86_64).
But I didn't updated luv, I saw @doronbehar is working on this in #80528
Additionally I've removed pulseaudio from the lua-packages.nix as you requested.

In my opinion this is safe to merge.

@GrahamcOfBorg build neovim luaPackages.lyaml luaPackages.cqueues

builds look ok but at runtime there may be issues. I will merge anyway.

100 packages built:
awesome gnvim knot-resolver lua51Packages.argparse lua51Packages.busted lua51Packages.cassowary lua51Packages.cqueues lua51Packages.http lua51Packages.ldoc lua51Packages.lpeglabel lua51Packages.lua-lsp lua51Packages.lua-messagepack lua51Packages.luacheck lua51Packages.luacov lua51Packages.luaposix lua51Packages.luasec lua51Packages.luasql-sqlite3 lua51Packages.luassert lua51Packages.luautf8 lua51Packages.lyaml lua51Packages.mpack lua51Packages.nvim-client lua51Packages.penlight lua51Packages.pulseaudio lua51Packages.rapidjson lua51Packages.std_normalize luaPackages.argparse luaPackages.busted luaPackages.cassowary luaPackages.cqueues luaPackages.http luaPackages.ldoc luaPackages.lpeglabel luaPackages.lua-lsp luaPackages.lua-messagepack luaPackages.luacheck luaPackages.luacov luaPackages.luaposix luaPackages.luasec luaPackages.luasql-sqlite3 luaPackages.luassert luaPackages.luautf8 luaPackages.lyaml luaPackages.mpack luaPackages.nvim-client luaPackages.penlight luaPackages.pulseaudio luaPackages.rapidjson luaPackages.std_normalize lua53Packages.argparse lua53Packages.busted lua53Packages.cassowary lua53Packages.cqueues lua53Packages.http lua53Packages.ldoc lua53Packages.lpeglabel lua53Packages.lua-lsp lua53Packages.lua-messagepack lua53Packages.luacheck lua53Packages.luacov lua53Packages.luaposix lua53Packages.luasec lua53Packages.luasql-sqlite3 lua53Packages.luassert lua53Packages.luautf8 lua53Packages.lyaml lua53Packages.mpack lua53Packages.nvim-client lua53Packages.penlight lua53Packages.pulseaudio lua53Packages.rapidjson lua53Packages.std_normalize luajitPackages.argparse luajitPackages.busted luajitPackages.cassowary luajitPackages.cqueues luajitPackages.http luajitPackages.ldoc luajitPackages.lpeglabel luajitPackages.lua-lsp luajitPackages.lua-messagepack luajitPackages.luacheck luajitPackages.luacov luajitPackages.luaposix luajitPackages.luasec luajitPackages.luasql-sqlite3 luajitPackages.luassert luajitPackages.luautf8 luajitPackages.lyaml luajitPackages.mpack luajitPackages.nvim-client luajitPackages.penlight luajitPackages.pulseaudio luajitPackages.rapidjson luajitPackages.std_normalize mudlet neovim-qt neovim-unwrapped prosody sile

I will try to update the lua documentation #55302 this WE.

As for the pulseaudio one, I wanted to move it to generated too see #78565 but didn't have the time: you would need to remove it from lua-packages.nix too cc @doronbehar

I don't care if my pulseaudio will move from one place to another, as long as I'm pinged to test something that's supposed to work. @teto I think the issue I wrote about here is orthogonal to #89145 (comment) - luaPackages.pulseaudio can't be compiled with overriding makeFlags I think and buildLuarocksPackage doesn't support these.

The cqueues update should be safe enough, I believe.

@doronbehar sry I forgot about that. Luarocks make buildSystem can accept variables passed by extraVariables or via luarocks make (while the cmake build system is closed). So this could be a simple override.

My lua.pkgs.pulseaudio package broke today after a system update. I've just made it through via an ugly overlay... I'm working on a nicer fix.

Sigh.... I really don't know what to do, it's working when I build it with a makefile, and when I use buildLuaPackage but not with buildLuarocksPackage.

@teto could it be something with the Makefile? https://github.com/doronbehar/lua-pulseaudio/blob/v0.2/Makefile

what I meant is that in so the extra args in the makefile could be passed to luarocks via an override so you dont need a manual one a priori.

extra args in the makefile could be passed to luarocks via an override so you dont need a manual one a priori.

@teto please do this:

1. Apply this diff on master:

diff --git i/pkgs/development/lua-modules/overrides.nix w/pkgs/development/lua-modules/overrides.nix
index 30be2c197a5..c88d375d5be 100644
--- i/pkgs/development/lua-modules/overrides.nix
+++ w/pkgs/development/lua-modules/overrides.nix
@@ -324,5 +324,10 @@ with super;
     nativeBuildInputs = [
       pkgs.pulseaudio pkgs.pkgconfig
     ];
+    extraVariables = {
+      INST_LIBDIR = "${placeholder "out"}/lib/lua/${lua.luaversion}";
+      INST_LUADIR = "${placeholder "out"}/share/lua/${lua.luaversion}";
+      LUA_BINDIR = "${placeholder "out"}/bin";
+    };
   });
 }

2. Then run:

ldd $(nix-build -A luajitPackages.pulseaudio)/lib/lua/5.1/pulseaudio.so

3. Then checkout lua.pkgs.pulseaudio: Move from generated to lua-packages.nix #89767 and run again:

ldd $(nix-build -A luajitPackages.pulseaudio)/lib/lua/5.1/pulseaudio.so

And you should be able to see that pulseaudio.so is not linked almost at all in the (2) case while it should be linked in (3).

cool that you tried ! sry if I dont answer quickly I am pretty swamped at the moment. Maybe it would accept the extra varialbes if https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/interpreters/lua-5/build-lua-package.nix#L228 was changed to $LUAROCKS make --deps-mode=all --tree=$out ''${rockspecFilename} $PULSEAUDIO_EXTRA_VARIABLES .... ? I think there is sthg related to that in the luarocks make builder.

was changed to $LUAROCKS make --deps-mode=all --tree=$out ''${rockspecFilename} $PULSEAUDIO_EXTRA_VARIABLES ....

I don't understand - I never heard of this env variable before - $PULSEAUDIO_EXTRA_VARIABLES.

Now I notice, that also when I run luarocks make inside the lua-pulseaudio repo, ldd shows that the result pulseaudio.so is not well linked. Here's the output of luarocks --verbose make --local ./pulseaudio-0.2-1.rockspec when I run it inside my lua-pulseaudio repo (EDIT): Here's a gist:

https://gist.github.com/0fadaebd60bdf6ea0540f2b8990516de

The most interesting part is: https://gist.github.com/doronbehar/0fadaebd60bdf6ea0540f2b8990516de#file-luarocks-make-log-L45 - it's as if luajit isn't found by pkg-config....

The warnings there remind me of luarocks/luarocks#1155 (comment) 😞 .