Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libjpeg_drop: remove #89550

Merged
merged 1 commit into from Jun 6, 2020
Merged

libjpeg_drop: remove #89550

merged 1 commit into from Jun 6, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jun 5, 2020 •
edited

Motivation for this change

Fixes #89535

The drop patches have been upstreamed to libjpeg 9d

There are no occurences of "libjpeg_drop" in the whole nixpkgs tree.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak mentioned this pull request Jun 5, 2020
Closed
veprbl
veprbl reviewed Jun 5, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs/pkgs/development/libraries/libjpeg/default.nix

Line 6 in d67e2a2

name = "libjpeg-9d";

so we could add an alias to libjpeg_original in pkgs/top-level/aliases.nix

@prusnak
libjpeg_drop: remove
88f5f97 
The drop patches have been upstreamed to libjpeg 9d
@prusnak
Copy link
Member Author

prusnak commented Jun 5, 2020

Added alias in 88f5f97

@veprbl veprbl merged commit c1728ad into NixOS:master Jun 6, 2020
@veprbl
Copy link
Member

veprbl commented Jun 6, 2020

Thank you!

@prusnak prusnak deleted the drop-libjpeg-drop branch June 6, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wamserma wamserma wamserma approved these changes

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

please delete libjpeg-drop
3 participants
@prusnak @veprbl @wamserma