Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python2Packages.pillow: freeze at 6.2.2 #89588

Merged
merged 1 commit into from Jun 6, 2020

Conversation

jonringer
Copy link
Contributor

Motivation for this change

fixes calibre

addresses 0e5e6b0#commitcomment-39708178

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner June 6, 2020 03:32
@adisbladis
Copy link
Member

@GrahamcOfBorg build calibre nixops

@evanjs
Copy link
Member

evanjs commented Jun 8, 2020

Argh. Thanks @jonringer!
I should have figured there would be more breakages than nixpkgs-review would show.

Moving forward, is it a good idea to write things like pillow/6 proactively/when bumping major versions? Or just as the need arises?

@jonringer
Copy link
Contributor Author

@evanjs it's more for the python2/3 divide than a major version on a given package. In general we don't want many versions of the same package in python-modules, but if a given interpreter is only able to see one version, then that's alright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nixops fails to build on master
3 participants