New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix breaking change in lv2 1.18.0 #89545
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
2.status: merge conflict
8.has: package (new)
and removed
2.status: merge conflict
labels
Jun 5, 2020
magnetophon
requested review from
jtojnar,
matthewbauer,
Ericson2314 and
doronbehar
June 7, 2020 15:30
jtojnar
reviewed
Jun 7, 2020
magnetophon
force-pushed
the
lv2_1_18_0
branch
2 times, most recently
from
June 8, 2020 15:11
a1e2c45
to
c94e5ea
Compare
jtojnar
reviewed
Jun 8, 2020
jtojnar
reviewed
Jun 8, 2020
magnetophon
force-pushed
the
lv2_1_18_0
branch
2 times, most recently
from
June 9, 2020 03:52
0b7ec65
to
9cf6e50
Compare
fix build with lv2 1.18.0
Thank you. |
@jtojnar Thank you! If you are interested, I have a bunch of other, mostly audio related, PR's open! ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a breaking change in lv2 1.18.0, various packages didn't build anymore since 02065f4
This PR fixes the ones I have found, there might be more.
21836f4 should also fix #87819
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)