Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking change in lv2 1.18.0 #89545

Merged
merged 10 commits into from Jun 11, 2020
Merged

Fix breaking change in lv2 1.18.0 #89545

merged 10 commits into from Jun 11, 2020

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Jun 5, 2020

Due to a breaking change in lv2 1.18.0, various packages didn't build anymore since 02065f4

This PR fixes the ones I have found, there might be more.

21836f4 should also fix #87819

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@magnetophon magnetophon force-pushed the lv2_1_18_0 branch 2 times, most recently from a1e2c45 to c94e5ea Compare June 8, 2020 15:11
@magnetophon magnetophon force-pushed the lv2_1_18_0 branch 2 times, most recently from 0b7ec65 to 9cf6e50 Compare June 9, 2020 03:52
@ofborg ofborg bot requested a review from pmahoney June 9, 2020 03:54
@jtojnar
Copy link
Contributor

jtojnar commented Jun 11, 2020

Thank you.

@magnetophon magnetophon deleted the lv2_1_18_0 branch June 11, 2020 19:59
@magnetophon
Copy link
Member Author

@jtojnar Thank you!

If you are interested, I have a bunch of other, mostly audio related, PR's open! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken 'lsp-plugins' prevents us from building 'pulseeffects' in current master
2 participants