pipewire: apply patch providing absolute path to pipewire-media-session #89611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jsravn |
10 tasks
|
Seems fine to me, do we need this patch in 20.03? |
|
Upstream had some feedback on the PR - as this change doesn't allow to run from the source folder anymore. @jtojnar, do you an idea if this can still be accomplished with meson somehow? If not, we should ship the patch inside nixpkgs.
|
flokli
force-pushed
the
pipewire-media-session-absolue-path
branch
from
44e04df
to
28a3ccc
Compare
|
I rebased on top of master (which includes the bump to 0.3.6), and updated the patch url to the commit that landed in master (not yet released). @jtojnar , can you take a look? |
jtojnar
reviewed
Jun 10, 2020
So pipewire-daemon is able to locate pipewire-media-session (which it's executing). Context: NixOS#89528 (comment)
flokli
force-pushed
the
pipewire-media-session-absolue-path
branch
from
28a3ccc
to
2d54430
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So pipewire-daemon is able to locate pipewire-media-session (which it's
executing).
Context: #89528 (comment)
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)