Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipewire_0_2: move from 2.nix to 0.2.nix #89613

Merged
merged 1 commit into from Jun 7, 2020
Merged

pipewire_0_2: move from 2.nix to 0.2.nix #89613

merged 1 commit into from Jun 7, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jun 6, 2020

This wrongly suggests there's a 2.x version.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
pipewire_0_2: move from 2.nix to 0.2.nix
a382d06 
This wrongly suggests there's a 2.x version.
@worldofpeace worldofpeace merged commit 131028c into NixOS:master Jun 7, 2020
@worldofpeace
Copy link
Contributor

@flokli You can request review from @NixOS/gnome btw

@flokli flokli deleted the pipewire_0_2_version branch September 27, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

@primeos primeos Awaiting requested review from primeos

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @worldofpeace