Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyxdg: fix call to missing class field Type #89570

Merged
merged 1 commit into from Jun 8, 2020
Merged

pyxdg: fix call to missing class field Type #89570

merged 1 commit into from Jun 8, 2020

Conversation

mjlbach
Copy link
Contributor

@mjlbach mjlbach commented Jun 5, 2020 •
edited

Motivation for this change

Fixes #88593

I've submitted this upstream at pyxdg here: https://gitlab.freedesktop.org/xdg/pyxdg/-/merge_requests/5

To test:

nix-shell -p -I nixpkgs=$NIXPKGS "python3.withPackages (ps: with ps; [ pyxdg ])" --command "python -c 'from xdg.Menu import parse;parse()'"
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mjlbach
Copy link
Contributor Author

mjlbach commented Jun 5, 2020

@lourkeur Can you look at this one?

@ofborg ofborg bot requested a review from domenkozar June 5, 2020 23:01
This was referenced Jun 5, 2020
Closed
Open
@mjlbach mjlbach changed the title Patch pyxdg to fix error accessing missing class property Type Patch pyxdg to fix error accessing missing class fieldType Jun 5, 2020
@mjlbach mjlbach changed the title Patch pyxdg to fix error accessing missing class fieldType Patch pyxdg to fix error accessing missing class field (Type) Jun 5, 2020
@jonringer
Copy link
Contributor

does gitlab have a patch endpoint where you fetch it? I would much prefer that than checking a local patch into repo (especially since the patch isn't NixOS specific)

@mjlbach
Copy link
Contributor Author

mjlbach commented Jun 5, 2020

I would much prefer that than checking a local patch into repo (especially since the patch isn't NixOS specific)

Done

bbjubjub2494 added a commit to bbjubjub2494/nur-expressions that referenced this pull request Jun 6, 2020
@bbjubjub2494
switch xpra to NixOS/nixpkgs#89570
a671efe
@flokli
Copy link
Contributor

flokli commented Jun 6, 2020

Can you format the commit message according to CONTRIBUTING.md?

@mjlbach
pyxdg: fix missing class field Type
1968f11 
Fixes NixOS#88593 by replacing call to missing Type field with getType()
@mjlbach
Copy link
Contributor Author

mjlbach commented Jun 6, 2020 •
edited

@flokli done
@lourkeur I fixed the added space

@mjlbach mjlbach changed the title Patch pyxdg to fix error accessing missing class field (Type) pyxdg: fix call to missing class field (Type) Jun 6, 2020
@mjlbach mjlbach changed the title pyxdg: fix call to missing class field (Type) pyxdg: fix call to missing class field Type Jun 6, 2020
@bbjubjub2494
Copy link
Member

I can confirm this fixes #88593 when applied in my KDE VM.

@flokli flokli merged commit be483c8 into NixOS:master Jun 8, 2020
@mjlbach mjlbach mentioned this pull request Jun 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

@bbjubjub2494 bbjubjub2494 bbjubjub2494 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pyxdg: AttributeError: 'MenuEntry' object has no attribute 'Type' on KDE plasma
4 participants
@mjlbach @jonringer @flokli @bbjubjub2494