Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

input-utils: Fix cross-compilation #89571

Merged
merged 1 commit into from
Jun 5, 2020
Merged

input-utils: Fix cross-compilation #89571

merged 1 commit into from
Jun 5, 2020
+1 −1

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Jun 5, 2020

We actually don't need to strip using install. Stripping is already
part of the fixup. This ends up being a fix we can apply universally,
but works around an issue where install doesn't know about the
prefixed strip binary.

Motivation for this change

I completely forgot that this trivial fix is needed for mobile-nixos/mobile-nixos#155 to compile successfully.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • Mobile NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@samueldr
input-utils: Fix cross-compilation
68096ca 
We actually don't need to `strip` using `install`. Stripping is already
part of the fixup. This ends up being a fix we can apply universally,
but works around an issue where `install` doesn't know about the
prefixed `strip` binary.
@samueldr samueldr mentioned this pull request Jun 5, 2020
Closed
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 5, 2020
@samueldr samueldr merged commit 3570c13 into NixOS:master Jun 5, 2020
@samueldr samueldr deleted the fix/input-utils/cross branch June 7, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@samueldr