Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode, vscodium: 1.45.0 -> 1.45.1 #89620

Merged
merged 1 commit into from Jun 10, 2020
Merged

vscode, vscodium: 1.45.0 -> 1.45.1 #89620

merged 1 commit into from Jun 10, 2020

Conversation

kuznero
Copy link
Member

@kuznero kuznero commented Jun 6, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@eadwu eadwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified hashes.

@kuznero
Copy link
Member Author

kuznero commented Jun 10, 2020

What prevents this PR to be merged?

@Mic92
Copy link
Member

Mic92 commented Jun 10, 2020

Result of nixpkgs-review pr 89620 1

3 packages built:
- vscode
- vscode-with-extensions
- vscodium

@Mic92 Mic92 merged commit 496bc90 into NixOS:master Jun 10, 2020
@kuznero kuznero deleted the vscode branch June 11, 2020 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants