nixos/freeswitch: Unit improvements and add fs_cli #89558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misuzu
reviewed
Jun 5, 2020
| @@ -95,9 +95,11 @@ in { | |||
| -conf ${configPath} \\ | |||
| -base /var/lib/freeswitch"; | |||
| ExecReload = "${pkg}/bin/fs_cli -x reloadxml"; | |||
| Restart = "always"; | |||
| Restart = "on-failure"; | |||
There was a problem hiding this comment.
What is the use case for this?
There was a problem hiding this comment.
This way, fs_cli -x 'fsctl shutdown elegant' works without starting the daemon afterwards, while fs_cli -x 'fsctl crash' will cause it to be restarted afterwards.
misuzu
reviewed
Jun 5, 2020
| }; | ||
| }; | ||
| environment.systemPackages = pkg; |
There was a problem hiding this comment.
error: The option value `environment.systemPackages' in `nixpkgs/nixos/modules/services/misc/freeswitch.nix' is not of type `list of packages'.
There was a problem hiding this comment.
Oh, forgot to git add :/ Force-pushed it
This switches the unit to Restart=on-failure and switches the CPU policy to fifo (the daemon tries to do that itself, but is denied permission). Also add the package to $PATH to be able to use fs_cli easily.
misuzu
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the unit to Restart=on-failure and switches the CPU policy
to fifo (the daemon tries to do that itself, but is denied permission).
Also add the package to $PATH to be able to use fs_cli easily.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)