Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.jsonrpc{client,server}: init at {3.3.6,4.1.3} #89549

Closed
wants to merge 3 commits into from
Closed

python3Packages.jsonrpc{client,server}: init at {3.3.6,4.1.3} #89549

wants to merge 3 commits into from

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jun 5, 2020 •
edited

Motivation for this change

Add new Python packages which are dependencies of the upcoming Electrum 4.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
Copy link
Member Author

prusnak commented Jun 6, 2020 •
edited

Reworked the PR to checkout from GitHub not PyPI (so the tests subfolder is included) and added checkPhase = "pytest"; to each package.

@prusnak prusnak mentioned this pull request Jun 6, 2020
Closed
@prusnak
Copy link
Member Author

prusnak commented Jun 10, 2020

Not needed anymore. Electrum maintainers just removed these dependencies before the 4.0 release: spesmilo/electrum@30f5be2

@prusnak prusnak closed this Jun 10, 2020
@prusnak prusnak deleted the jsonrpcclientserver branch June 10, 2020 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @jonringer