Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] phpPackages.phpstan: 0.12.4 -> 0.12.25 #87980

Merged
merged 1 commit into from May 17, 2020
Merged

[20.03] phpPackages.phpstan: 0.12.4 -> 0.12.25 #87980

merged 1 commit into from May 17, 2020

Conversation

talyz
Copy link
Contributor

@talyz talyz commented May 16, 2020

Motivation for this change

Update phpPackages.phpstan to the latest release on stable, where it's been lagging behind master quite a bit.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@talyz talyz requested a review from etu as a code owner May 16, 2020 20:44
@etu etu merged commit a1fe909 into NixOS:release-20.03 May 17, 2020
@talyz talyz deleted the phpstan-0.12.25-20.03 branch May 18, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@talyz @etu