Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.tart: unmark as broken #87972

Merged
merged 1 commit into from May 17, 2020
Merged

haskellPackages.tart: unmark as broken #87972

merged 1 commit into from May 17, 2020

Conversation

pacien
Copy link
Contributor

@pacien pacien commented May 16, 2020

Motivation for this change

Dependency issues for this package have been fixed in the latest release.
See jtdaugherty/tart#10

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pacien pacien requested a review from cdepillabout as a code owner May 16, 2020 20:01
@cdepillabout
Copy link
Member

@pacien Could rebase this on the haskell-updates branch, and change the base branch in the github ui to haskell-updates as well?

When sending PRs for haskell stuff here in nixpkgs, we normally like to send them to the haskell-updates branch, no master.

Once you do this, I will merge this PR in.

@pacien
haskellPackages.tart: unmark as broken
6f9d2f5 
Dependency issues for this package have been fixed in the latest release.
See jtdaugherty/tart#10
@pacien pacien force-pushed the haskellpackages-tart-unbreak-0.2 branch from d587e55 to 6f9d2f5 Compare May 17, 2020 02:56
@pacien pacien changed the base branch from master to haskell-updates May 17, 2020 02:56
@pacien
Copy link
Contributor Author

pacien commented May 17, 2020

Done!

@cdepillabout
Copy link
Member

Looks good, thanks! Compiles fine for me.

@cdepillabout cdepillabout merged commit d604d1e into NixOS:haskell-updates May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pacien @cdepillabout