Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shattered-pixel-dungeon: 0.7.5f -> 0.8.0b #87947

Merged
merged 1 commit into from Jun 19, 2020
Merged

shattered-pixel-dungeon: 0.7.5f -> 0.8.0b #87947

merged 1 commit into from Jun 19, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented May 16, 2020

Motivation for this change

The desktop and mobile versions are now unified. This required a few
changes to dependencies and patching.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fgaz
shattered-pixel-dungeon: 0.7.5f -> 0.8.0b
376a013 
The desktop and mobile versions are now unified. This required a few
changes to dependencies and patching.
@fgaz
Copy link
Member Author

fgaz commented Jun 18, 2020

/marvin opt-in
/status needs_review

@marvin-mk2
Copy link

marvin-mk2 bot commented Jun 18, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. The stages are

  • needs_review, if the author considers this PR ready
  • needs_work if the PR in its current form is not ready yet. Maybe the reviewer requested changes, there is an ongoing discussion or you are waiting for upstream feedback.
  • needs_merge can be set by reviewers who do not have merge permission but would merge this PR if they could.

Anybody can switch the current status with a comment of the form /status <new_status_here>.

Feedback and contributions to this bot are appreciated.

@timokau
Copy link
Member

timokau commented Jun 19, 2020

Please check the nix-review checkmark in the future, even when the package is a leaf package. Makes reviewing easier (since it may not be obvious to the reviewer that it is a leaf).

Thanks for the update!
/status needs_merge

@marvin-mk2 marvin-mk2 bot requested a review from timokau June 19, 2020 21:50
@timokau timokau merged commit 6a438db into NixOS:master Jun 19, 2020
@timokau timokau mentioned this pull request Jun 19, 2020
Merged
@fgaz fgaz deleted the shattered-pixel-dungeon/0.8.0b branch June 21, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fgaz @timokau