Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ksuperkey: git-2015-07-21 -> 0.4 #87995

Merged
merged 1 commit into from May 17, 2020
Merged

ksuperkey: git-2015-07-21 -> 0.4 #87995

merged 1 commit into from May 17, 2020

Conversation

IvarWithoutBones
Copy link
Member

@IvarWithoutBones IvarWithoutBones commented May 17, 2020 •
edited

Motivation for this change

update to a stable (and newer) release instead of a random git rev + cleanup

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

marsam
marsam reviewed May 17, 2020
View reviewed changes
pkgs/tools/X11/ksuperkey/default.nix Outdated Show resolved Hide resolved
pkgs/tools/X11/ksuperkey/default.nix Outdated Show resolved Hide resolved
pkgs/tools/X11/ksuperkey/default.nix Outdated Show resolved Hide resolved
@IvarWithoutBones
Copy link
Member Author

All done 👍

@marsam marsam merged commit d7c0d31 into NixOS:master May 17, 2020
@IvarWithoutBones IvarWithoutBones deleted the ksuperkey branch May 17, 2020 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IvarWithoutBones @marsam