Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomacs: 3.12 -> 3.14.2 #87933

Merged
merged 1 commit into from May 16, 2020
Merged

nomacs: 3.12 -> 3.14.2 #87933

merged 1 commit into from May 16, 2020

Conversation

Mindavi
Copy link
Contributor

@Mindavi Mindavi commented May 16, 2020

Motivation for this change

Just tried to install this package and found out it's broken on unstable (see https://hydra.nixos.org/build/119101874). Updating to the latest version seems to fix the build (for me), so that seems like a good solution.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @ahmedtd

@marsam marsam merged commit ec61423 into NixOS:master May 16, 2020
This was referenced May 26, 2020
Merged
Merged
@Mindavi Mindavi deleted the nomacs/3.14.2 branch November 21, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mindavi @marsam