Add shamilton to maintainers #87935
Add shamilton to maintainers #87935
Conversation
|
Please rename the PR or drop 9c7dcca from this PR. |
| email = "sgn.hamilton@protonmail.com"; | ||
| github = "SCOTT-HAMILTON"; | ||
| githubId = 24496705; | ||
| }; |
There was a problem hiding this comment.
Please sort entries for better readability.
There was a problem hiding this comment.
your package should be inserted in the wider nixpkgs with a callPackage expression in pkgs/top-level/all-packages.nix
Also please confirm that the point of this PR is to init otpgen.
EDIT: #87887
| name = "OTPGen"; | ||
|
|
||
| meta = { | ||
| description = "MULTI-PURPOSE OTP TOKEN GENERATOR WRITTEN IN C++ AND QT WITH ENCRYPTION AND SYSTEM TRAY ICON. SUPPORTS TOTP, HOTP, AUTHY AND STEAM AND CUSTOM DIGIT LENGTHS AND PERIODS."; |
There was a problem hiding this comment.
All caps is inappropriate here. The period as well. please conform to the manual.
| license = lib.licenses.mit; | ||
| homepage = "https://github.com/magiruuvelvet/OTPGen"; | ||
| maintainers = [ "Scott Hamilton <sgn'dot'hamilton'at'protonmail'dot'com>" ]; | ||
| priority = "10"; |
There was a problem hiding this comment.
why does this package need to be low-priority?
| homepage = "https://github.com/magiruuvelvet/OTPGen"; | ||
| maintainers = [ "Scott Hamilton <sgn'dot'hamilton'at'protonmail'dot'com>" ]; | ||
| priority = "10"; | ||
| timeout = 3600; |
There was a problem hiding this comment.
Why does this package need a timeout?
| @@ -0,0 +1,42 @@ | |||
| { | |||
| pkgs ? import <nixpkgs> {} | |||
There was a problem hiding this comment.
default arguments shouldn't be used within nixpkgs. please use something like
{
lib,
stdenv,
makeWrapper,
fetchFromGithub,
fakeSha256
cmake,
pkg-config,
cryptopp,
qtbase,
}:
Co-authored-by: Louis Bettens <lourkeur@users.noreply.github.com>
|
Moved to #87938 |
Motivation for this change
Wasn't yet on the maintainers list.
Things done
Added Scott Hamilton aka me to the list.