htmlbeautifier: init at 1.3.1 #87928

mveytsman · 2020-05-16T07:04:36Z

Motivation for this change

Adds htmlbeautifier an HTML formatter with Ruby/ERB support.

Things done

doronbehar · 2020-05-16T12:25:21Z

Don't know why, but please note that there's a CI evaluation error.

shazow · 2020-05-16T18:14:07Z

maintainers/maintainer-list.nix

+    email = "maxim@ontoillogicmal.com";
+    github = "mvetsman";
+    githubId = 34720;
+    name = "Max Vetsman";


Suggested change

email = "maxim@ontoillogicmal.com";

github = "mvetsman";

githubId = 34720;

name = "Max Vetsman";

email = "maxim@ontoillogical.com";

github = "mveytsman";

githubId = 34720;

name = "Max Veytsman";

<3 thanks @shazow

maintainers/maintainer-list.nix

doronbehar · 2020-05-16T18:43:02Z

pkgs/development/web/htmlbeautifier/default.nix

+  exes = [ "htmlbeautifier" ];
+
+  # toString prevents the update script from being copied into the nix store
+  passthru.updateScript = toString ./update;


Question: Do all bundlerApp packages use such an update script? The script it self seems trivial that I doubt there is no generic way of doing so. It seems there is something related to that according to https://nixos.org/nixpkgs/manual/#sec-language-ruby

I found similar ones in cocoapods but I see some that don't have it, e.g ruby-zoom and solargraph.

Do you think I should remove it?

I think cocoapods' update script is a just a bit "non-trivial" because it also handles a Gemfile-beta file for as far as I can see.

Can you try:

passthru.updateScript = bundlerUpdateScript "htmlbeautifier";

You should be able to check if this works with:

nix-shell maintainers/scripts/update.nix --argstr package htmlbeautifier

See https://nixos.org/nixpkgs/manual/#var-passthru-updateScript

@doronbehar ah amazing! thanks for clarifying. I changed it as you suggested and it seems to work.

Do all bundlerApp packages use such an update script?

Most "simple ruby packages" do, since: #64822.

doronbehar

LGTM but I'm no experienced in reviewing bundler PRs. Maybe @aanderse will have something more to add.

aanderse · 2020-05-20T00:21:58Z

Sorry, I can't be of help... I'm not a ruby guy 😞

mveytsman · 2020-05-20T23:52:09Z

No worries!

Do you know if there's anyone else we should ask for a 👀 on this PR?

kimat · 2020-05-22T12:42:37Z

I verified that:

nixpkgs-review pr 87928 works
[nix-shell:~/.cache/nixpkgs-review/pr-87928]$ htmlbeautifier --help works
the application works using : [nix-shell:~/.cache/nixpkgs-review/pr-87928]$ htmlbeautifier < a.html > b.html with sample files from https://github.com/threedaymonk/htmlbeautifier/blob/master/spec/documents_spec.rb

aanderse · 2020-06-07T21:39:21Z

Well... I hate to do it, but I'll bug @manveru for a quick review here.

manveru

Two small issues, looks good otherwise.

manveru · 2020-06-07T21:43:30Z

pkgs/development/web/htmlbeautifier/default.nix

+    description = "A normaliser/beautifier for HTML that also understands embedded Ruby, ideal for tidying up Rails templates";
+    homepage = "https://github.com/threedaymonk/htmlbeautifier";
+    license = licenses.mit;
+    platforms = platforms.linux;


This should probably be ruby.meta.platforms, since it's pure Ruby code and should run everywhere Ruby does?

manveru · 2020-06-07T21:44:08Z

pkgs/development/web/htmlbeautifier/default.nix

+  gemfile = ./Gemfile;
+  lockfile = ./Gemfile.lock;
+  gemset = ./gemset.nix;


This can be expressed as gemdir = ./.;

mveytsman · 2020-11-15T19:39:34Z

@manveru I'm really sorry I somehow missed this PR was still open with feedback from you until now ☹️

I went back and addressed your feedback. Is this good to be accepted now?

Sorry again for the hiatus!

pkgs/development/web/htmlbeautifier/gemset.nix

pkgs/development/web/htmlbeautifier/default.nix

SuperSandro2000 · 2021-03-21T03:05:39Z

@ofborg eval

By mistake

doronbehar

your PR should have eventually two commits:

maintainers: add <me>
<package-name>: init at <version>

stale · 2021-09-21T19:24:44Z

I marked this as stale due to inactivity. → More info

doronbehar · 2021-09-23T09:05:42Z

@mveytsman the PR looks good, only the commit log is not as it should be. There should be only two commits:

maintainers: add <me>
<package-name>: init at <version>

mveytsman · 2021-09-23T12:22:33Z

Fixed!

doronbehar · 2021-09-23T15:23:16Z

Error when testing the binary:

(ins)[nix-shell:~/.cache/nixpkgs-review/pr-87928]$ ./results/htmlbeautifier/bin/htmlbeautifier --help
Traceback (most recent call last):
        3: from ./results/htmlbeautifier/bin/htmlbeautifier:19:in `<main>'
        2: from /nix/store/w25m3pyvypghdi0shx1lg6z1d4g5lhz0-bundler-2.2.24/lib/ruby/gems/2.7.0/gems/bundler-2.2.24/lib/bundler.rb:149:in `setup'
        1: from /nix/store/w25m3pyvypghdi0shx1lg6z1d4g5lhz0-bundler-2.2.24/lib/ruby/gems/2.7.0/gems/bundler-2.2.24/lib/bundler/runtime.rb:13:in `setup'
/nix/store/w25m3pyvypghdi0shx1lg6z1d4g5lhz0-bundler-2.2.24/lib/ruby/gems/2.7.0/gems/bundler-2.2.24/lib/bundler/definition.rb:426:in `ensure_equivalent_gemfile_and_lockfile': You are trying to install in deployment mode after changing (Bundler::ProductionError)
your Gemfile. Run `bundle install` elsewhere and add the
updated ../../../../../nix/store/csw60zvq0rlf0494k86a598hyrh1jjl8-gemfile-and-lockfile/Gemfile.lock to version control.

If this is a development machine, remove the /nix/store/csw60zvq0rlf0494k86a598hyrh1jjl8-gemfile-and-lockfile/Gemfile freeze
by running ``.

The list of sources changed

You have added to the Gemfile:
* source: locally installed gems

ofborg bot added 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 16, 2020

mveytsman force-pushed the htmlbeautifier branch 2 times, most recently from 0d33666 to bf6dcff Compare May 16, 2020 17:56

shazow reviewed May 16, 2020

View reviewed changes

mveytsman force-pushed the htmlbeautifier branch from bf6dcff to 0d85897 Compare May 16, 2020 18:17

ofborg bot added the 11.by: package-maintainer label May 16, 2020

doronbehar reviewed May 16, 2020

View reviewed changes

mveytsman force-pushed the htmlbeautifier branch 2 times, most recently from b42acff to 01fc8d7 Compare May 19, 2020 01:38

doronbehar approved these changes May 19, 2020

View reviewed changes

manveru suggested changes Jun 7, 2020

View reviewed changes

ryantm added 2.status: merge conflict and removed 2.status: merge conflict labels Oct 3, 2020

mveytsman force-pushed the htmlbeautifier branch from 01fc8d7 to 913cd50 Compare November 15, 2020 00:23

ofborg bot removed the 2.status: merge conflict label Nov 15, 2020

mveytsman force-pushed the htmlbeautifier branch from 913cd50 to 71946be Compare November 15, 2020 19:37

mveytsman force-pushed the htmlbeautifier branch from 71946be to 09e1c7a Compare November 15, 2020 20:24

ofborg bot added the 10.rebuild-darwin: 1-10 label Nov 15, 2020

ofborg bot added 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 labels Nov 15, 2020

SuperSandro2000 requested changes Mar 21, 2021

View reviewed changes

pkgs/development/web/htmlbeautifier/gemset.nix Outdated Show resolved Hide resolved

pkgs/development/web/htmlbeautifier/default.nix Outdated Show resolved Hide resolved

doronbehar previously approved these changes Mar 24, 2021

View reviewed changes

doronbehar requested changes Mar 24, 2021

View reviewed changes

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 21, 2021

maintainers: add mveytsman

0199916

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 23, 2021

doronbehar added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 23, 2021

htmlbeautifier: init at 1.3.1

7e91825

mveytsman force-pushed the htmlbeautifier branch from c56097d to 7e91825 Compare September 23, 2021 12:19

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 23, 2021

Artturin added the 12.approvals: 1 label Apr 13, 2022

Artturin marked this pull request as draft May 1, 2022 23:08

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 30, 2022

wegank removed the 12.approvals: 1 label Mar 9, 2024

wegank added the 2.status: merge conflict label Mar 20, 2024

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

htmlbeautifier: init at 1.3.1 #87928

htmlbeautifier: init at 1.3.1 #87928

mveytsman commented May 16, 2020 •

edited

doronbehar commented May 16, 2020

shazow May 16, 2020

mveytsman May 16, 2020

doronbehar May 16, 2020

mveytsman May 16, 2020

doronbehar May 16, 2020

mveytsman May 19, 2020

kimat May 22, 2020 •

edited

doronbehar left a comment

aanderse commented May 20, 2020

mveytsman commented May 20, 2020

kimat commented May 22, 2020

aanderse commented Jun 7, 2020

manveru left a comment

manveru Jun 7, 2020

manveru Jun 7, 2020

mveytsman commented Nov 15, 2020

SuperSandro2000 commented Mar 21, 2021

doronbehar left a comment

stale bot commented Sep 21, 2021

doronbehar commented Sep 23, 2021

mveytsman commented Sep 23, 2021

doronbehar commented Sep 23, 2021

htmlbeautifier: init at 1.3.1 #87928

Are you sure you want to change the base?

htmlbeautifier: init at 1.3.1 #87928

Conversation

mveytsman commented May 16, 2020 • edited

Motivation for this change

Things done

doronbehar commented May 16, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kimat May 22, 2020 • edited

Choose a reason for hiding this comment

doronbehar left a comment

Choose a reason for hiding this comment

aanderse commented May 20, 2020

mveytsman commented May 20, 2020

kimat commented May 22, 2020

aanderse commented Jun 7, 2020

manveru left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mveytsman commented Nov 15, 2020

SuperSandro2000 commented Mar 21, 2021

doronbehar left a comment

Choose a reason for hiding this comment

stale bot commented Sep 21, 2021

doronbehar commented Sep 23, 2021

mveytsman commented Sep 23, 2021

doronbehar commented Sep 23, 2021

mveytsman commented May 16, 2020 •

edited

kimat May 22, 2020 •

edited