-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xpra: avoid double-wrapping #88021
xpra: avoid double-wrapping #88021
Conversation
not sure if this is related, but xpra gives me these errors:
|
I remember that, it looks like #41106 which I thought we fixed. can you elaborate on what derivation of xpra you are using and what commands you issued? |
|
The absence of double-wrapping breaks |
Ok it's fixed. It wasn't #41106, it was a different regression introduced by this change. I didn't hit it because I use xpra in CLI. Maybe it's better to keep the doublewrapping on account of don't fix it if it ain't broke? |
Motivation for this change
According to the manual, double-wrapping can and should be avoided. AFAIK no known bug is caused by this situation.
Things done
Tweak derivation to avoid double-wrapping.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)