Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Forkable to distinguish two kinds of iterators #2576

Closed
wants to merge 16 commits into from

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented May 17, 2020

  • The "ephemeral" iterators are vanilla STL iterators and not guaranteed to remain valid across changes to the container.
  • The "durable" iterators designate an entry in the container and must remain valid across changes to the container.

forkable_test.cpp shows how this could work. For the time being, in real code both ephemeral and durable iterators are map iterators, so this PR is mostly harmless.

Another contribution to #2570.

@eggrobin eggrobin added the LGTM label May 17, 2020
@pleroy pleroy closed this May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants