Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/CODEOWNERS: add podman team #87926

Merged
merged 1 commit into from May 16, 2020
Merged

.github/CODEOWNERS: add podman team #87926

merged 1 commit into from May 16, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented May 16, 2020

Until ofborg notifies maintainers for nixos/* this seems to be the alternative.

cc @NixOS/podman

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adisbladis adisbladis merged commit e5415d1 into NixOS:master May 16, 2020
@zowoq zowoq deleted the codeowners-podman branch May 16, 2020 09:25
@zowoq
Copy link
Contributor Author

zowoq commented May 16, 2020

This doesn't seem to work.

I'm hoping it just needs the nixpkgs repo to be added to the team* and not that the team needs commit access to be a codeowner?

*I've been asking for this to be done here: #84177 (comment)

@zowoq
Copy link
Contributor Author

zowoq commented May 27, 2020

The team needs write access to the repo for this to work. PR to revert #89024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants