Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pulumi Update 1.12.0 > 2.2.1 #88013

Closed
wants to merge 4 commits into from
Closed

Pulumi Update 1.12.0 > 2.2.1 #88013

wants to merge 4 commits into from

Conversation

mudrii
Copy link
Contributor

@mudrii mudrii commented May 17, 2020 •
edited

Motivation for this change

Update pulumi to new version 2.2.1
Add new core cloud plugin for pulumi Azure

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @peterromfeldhk @jlesquembre

@ofborg ofborg bot requested a review from jlesquembre May 17, 2020 10:12
@prusnak
Copy link
Member

prusnak commented May 17, 2020

Please read https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md and fix commit messages according to this document.

@mudrii mudrii mentioned this pull request May 17, 2020
Merged
10 tasks
@mudrii
Merge remote-tracking branch 'upstream/master'
99a65aa 
* upstream/master:
  glpaper: init at unstable-2020-03-30
  maintainers: add ccellado
@mudrii
Merge remote-tracking branch 'upstream/master'
91d9df6 
* upstream/master: (22 commits)
  mutt: 1.14.0 -> 1.14.1 (#88027)
  skaffold: 1.8.0 -> 1.9.1
  gerbil: 0.15.1 -> 0.16
  gerbilPackages.gerbil-utils: init at 2020-05-16
  obs-studio: 25.0.3 -> 25.0.8
  gerbil-unstable: 2020-02-27 -> 2020-05-17
  gambit-unstable: 2020-02-24 -> 2020-05-13
  Refactor Gerbil support
  Refactor Gambit support
  doas: enable timestamp by default and set pamdir
  nixos/zoneminder: add minimal test
  oh-my-zsh: 2020-05-11 -> 2020-05-16
  nixos/zoneminder: fix evaluation with php refactor
  nvi: mark as broken
  audacity: 2.3.3 -> 2.4.0
  adminer: 4.7.6 -> 4.7.7
  capstone: 4.0.1 -> 4.0.2
  portfolio: init at 0.46.3
  pueue: 0.4.0 -> 0.5.0
  obs-studio: use addOpenGLRunpath to enable nvenc
  ...
@MarcoPolo
Copy link
Contributor

I thought pulumi downloads the plugins when needed. Do these included plugins actually get used by the main pulumi-bin? I'm worried that it involves unnecessary downloads.

@mudrii
Copy link
Contributor Author

mudrii commented May 19, 2020

Maybe make sense to make modules separatly similar to terraform?

@mudrii
Copy link
Contributor Author

mudrii commented May 23, 2020

I will close this PR and create separate OR for update and azure

@mudrii mudrii closed this May 23, 2020
@jlesquembre
Copy link
Member

@mudrii some solution similar to terraform makes sense to me
@MarcoPolo pulumi downloads the plugins automatically, but they don't work in nix unless you patch them, see the comment in my PR #72373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlesquembre jlesquembre Awaiting requested review from jlesquembre

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mudrii @prusnak @MarcoPolo @jlesquembre