Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] sway: fix gtk wrapper #88018

Merged
merged 1 commit into from May 17, 2020
Merged

[20.03] sway: fix gtk wrapper #88018

merged 1 commit into from May 17, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 17, 2020 •
edited by ghost

(cherry picked from commit cdfad5a)

Motivation for this change

Backport of #86960 for 20.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested review from worldofpeace and primeos May 17, 2020 11:49
@ofborg ofborg bot requested review from Synthetica9 and Ma27 May 17, 2020 11:57
@primeos
Copy link
Member

primeos commented May 17, 2020 •
edited

@elyhaka you somehow cherry-picked another commit that is not in Nixpkgs (edit: I just remembered that I used squash and merge). The original commit should be in the master branch of NixOS/nixpkgs, i.e. cdfad5a in this case (sorry for having to point out this minor detail, but let's do this properly). If you want I could also take care of the backport.

@ghost
Copy link
Author

ghost commented May 17, 2020 •
edited by ghost

@primeos: That was the commit I had on my local branch, not sure why it changed it hash ? And when I compared it to the original PR and it seemed to be the same. You can handle it if you prefer.

edit: just saw your edit, ok, got how I got there.

@Ma27 Ma27 changed the title sway: fix gtk wrapper [20.03] sway: fix gtk wrapper May 17, 2020
sway: Fix the GTK wrapper (#86960)
83cffb9 
Fixes #67704.

(cherry picked from commit cdfad5a)
@primeos
Copy link
Member

primeos commented May 17, 2020

@elyhaka thanks :)

@primeos primeos merged commit 2eb0da8 into NixOS:release-20.03 May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@primeos primeos Awaiting requested review from primeos

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@primeos