Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpd: enable tests + install docs + split outputs #87949

Merged
merged 4 commits into from Jun 5, 2020
Merged

mpd: enable tests + install docs + split outputs #87949

merged 4 commits into from Jun 5, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented May 16, 2020 •
edited

Motivation for this change

I want to have the docs installed and they aren't installed if mesonFlags don't include -Ddocumentation=true.

Also, I noticed there are tests which I enabled.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar mentioned this pull request May 16, 2020
Closed
10 tasks
@ofborg ofborg bot requested review from tobim, astsmtl, ehmry and fpletz May 16, 2020 14:17
@doronbehar doronbehar changed the title mpd: enable tests + install docs to split outputs mpd: enable tests + install docs + split outputs May 16, 2020
@doronbehar doronbehar mentioned this pull request May 30, 2020
Closed
10 tasks
@marsam marsam merged commit 810f240 into NixOS:master Jun 5, 2020
@doronbehar doronbehar mentioned this pull request Jun 6, 2020
Merged
10 tasks
@doronbehar doronbehar deleted the mpd-docs branch March 2, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@ehmry ehmry ehmry approved these changes

@tobim tobim Awaiting requested review from tobim

@astsmtl astsmtl Awaiting requested review from astsmtl

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @marsam @ehmry