Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glpaper: init at unstable-2020-03-30 #87953

Merged
merged 2 commits into from May 17, 2020
Merged

glpaper: init at unstable-2020-03-30 #87953

merged 2 commits into from May 17, 2020

Conversation

ccellado
Copy link
Contributor

Motivation for this change

Add new useful package to the Wayland stack.

Things done

Added glpaper package.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ccellado ccellado mentioned this pull request May 16, 2020
Closed
10 tasks
@ccellado ccellado closed this May 16, 2020
@ccellado ccellado reopened this May 16, 2020
@jtojnar
Copy link
Contributor

jtojnar commented May 16, 2020

Could you also rebase the branch to fixup Update pkgs/development/tools/glpaper/default.nix onto the glpaper commit?

@ccellado
Copy link
Contributor Author

Could you also rebase the branch to fixup Update pkgs/development/tools/glpaper/default.nix onto the glpaper commit?

Squashed, did that

@jtojnar
Copy link
Contributor

jtojnar commented May 16, 2020

Could you also move the maintainer commit before the package commit (e.g. using git rebase -i HEAD^^). Otherwise there will be broken evaluation which might break git bisect.

@ccellado
Copy link
Contributor Author

Could you also move the maintainer commit before the package commit (e.g. using git rebase -i HEAD^^). Otherwise there will be broken evaluation which might break git bisect.

Looks like it worked.

@jtojnar
Copy link
Contributor

jtojnar commented May 17, 2020

Could you please push the changes?

@ccellado
Copy link
Contributor Author

Could you please push the changes?

I don't quite understand. I've pushed after reordering, my commit list here displays Maintainer commit before the main commit.

@jtojnar
Copy link
Contributor

jtojnar commented May 17, 2020

Hmm, you are right, GitHub just displays them in the wrong order here:

image

@jtojnar jtojnar merged commit c19fa9b into NixOS:master May 17, 2020
@jtojnar
Copy link
Contributor

jtojnar commented May 17, 2020

Thanks.

@ccellado
Copy link
Contributor Author

Thanks.

Thank your patience, I'm new to contributing <3

@ccellado ccellado deleted the glpaper-unstable branch May 17, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ccellado @jtojnar @taikatytto