Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ptvsd: init at 4.3.2 #88005

Closed
wants to merge 2 commits into from
Closed

pythonPackages.ptvsd: init at 4.3.2 #88005

wants to merge 2 commits into from

Conversation

leungbk
Copy link
Member

@leungbk leungbk commented May 17, 2020

Motivation for this change

Add ptvsd, a Python debugging tool compliant with the Debug Adapter Protocol.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@leungbk
Copy link
Member Author

leungbk commented May 18, 2020 via email

@leungbk leungbk requested a review from ptrhlm May 18, 2020 15:41
@jonringer
Copy link
Contributor

thanks for opening your first PR! :)

@leungbk
Copy link
Member Author

leungbk commented May 19, 2020 via email •
edited

@leungbk leungbk requested a review from jonringer May 19, 2020 02:49
@leungbk leungbk mentioned this pull request May 22, 2020
Merged
10 tasks
ptrhlm
ptrhlm approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@ptrhlm ptrhlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested your changes with Python 3.7 and VS Code. Seems to work. Great job

jonringer
jonringer reviewed May 29, 2020
View reviewed changes
pkgs/development/python-modules/ptvsd/default.nix
Comment on lines +13 to +14
# no tests in the wheel or the zip
doCheck = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no tests included. Please try to checkout from source and check if they have unit tests, and try to run them. Unit tests give a good indication that they package has a high degree of validity and correctness given the python package set.

If tests are not available, then please use pythonImportsCheck to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors.

@leungbk
Copy link
Member Author

leungbk commented Jun 6, 2020

Apparently ptvsd was deprecated May 4, well before I made this PR, but it was advertised on the deprecate branch and not on the master branch: https://github.com/microsoft/ptvsd/tree/deprecate

So I'll close this.

@leungbk leungbk closed this Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@ptrhlm ptrhlm ptrhlm approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leungbk @jonringer @ptrhlm