Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #139: Make --cache-dir work, and avoid creating dirs with --no-cache #144

Merged
merged 2 commits into from May 17, 2020

Conversation

FLHerne
Copy link
Contributor

@FLHerne FLHerne commented May 16, 2020

Supersedes #142.

cache_data.fromfile(cache_file, cache_size)
assert cache_size == len(cache_data)
self.cache_time = os.path.getmtime(self.cache_filename)
# cache_file is closed by `with` block, but index_file is still open.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is less than ideal, the close() is way too far down. But at least this change makes it better.

@FLHerne FLHerne merged commit 279402b into OpenTTD:master May 17, 2020
@FLHerne FLHerne deleted the flh-fix-options-2 branch April 2, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants