Fix: Desync after house replacement #8151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Digging through #7603 (comment). This fixes the desync that happens in Town::stations_near after the town replaces a house in 1.10.1 and master(83cd040).
Steps to reproduce (in master): run with -d desync=2, load attached save, unpause.
house-replacement-acceptance-desync.zip
Unlike JGRennison/OpenTTD-patches@326dfd3 this fix also handles the case when house was relocated.
Also improved the performance of RemoveNearbyStations as it's now called more often.