Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wabt: fix patch hash #87951

Merged
merged 1 commit into from May 16, 2020
Merged

wabt: fix patch hash #87951

merged 1 commit into from May 16, 2020

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented May 16, 2020

Motivation for this change

#46764 (comment)
There shouldn't be any more updates since the PR was approved.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Ekleog May 16, 2020 15:40
@Ekleog
Copy link
Member

Ekleog commented May 16, 2020

Ofborg reports another hash… let's try again?

@ofborg build wabt wabt.passthru.tests

@Ekleog
Copy link
Member

Ekleog commented May 16, 2020

Nope, wasn't a temporary failure from github -- looks like the sha256 you want is 1nh1ddsak6w51np17xf2r7i0czxrjslz1i4impmmp88h5bp2yjba

@eadwu
Copy link
Member Author

eadwu commented May 16, 2020

Oh my mistake, used nix-prefetch-url to fetch the hash, forgot fetchpatch doesn't use the same hash. Fixed.

@Ekleog
Copy link
Member

Ekleog commented May 16, 2020

Checking the darwin build

@ofborg build wabt wabt.passthru.tests

@Ekleog
Copy link
Member

Ekleog commented May 16, 2020

Looks good! Thank you for the PR :)

@Ekleog Ekleog merged commit f4b89bf into NixOS:master May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ekleog Ekleog Awaiting requested review from Ekleog

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eadwu @Ekleog