Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fdkaac: init at 1.0.0 #87952

Merged
merged 2 commits into from Jun 4, 2020
Merged

fdkaac: init at 1.0.0 #87952

merged 2 commits into from Jun 4, 2020

Conversation

lunik1
Copy link
Contributor

@lunik1 lunik1 commented May 16, 2020 •
edited

Motivation for this change

Adds cli for fdk aac encoding. Needed as a dependency in upcoming patch adding m4b-tool (edit: #87957).

Currently has a very similar name to fdk_aac, aka libfdk-aac. Open to suggestions on alternative names for this package if needed - fdkaac-cli maybe?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lunik1
Copy link
Contributor Author

lunik1 commented May 16, 2020

D'oh, forgot a capital at the beginning of the description!

@lunik1 lunik1 mentioned this pull request May 16, 2020
Closed
10 tasks
@lunik1 lunik1 requested a review from etu May 17, 2020 23:54
@etu
Copy link
Contributor

etu commented May 18, 2020

@ofborg build fdkaac

etu
etu approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@etu etu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to build and run fine for me, but as @lunik1 mentioned the name could be misleading.

I think the code as is is fine, but might be worth renaming the attribute to append -cli at the end of it to make the difference more clear.

@lunik1
Copy link
Contributor Author

lunik1 commented May 21, 2020

Possible alternative: homebrew calls this fdk-aac-encoder.

@lunik1
Copy link
Contributor Author

lunik1 commented Jun 3, 2020

I've gone with fdk-aac-encoder since I figure it's better to share a name with one other package managment systems than zero other package management systems.

@lunik1 lunik1 requested a review from etu June 3, 2020 19:08
@etu etu merged commit 88f61c3 into NixOS:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lunik1 @etu