New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
summon: init at 0.8.2 #87969
summon: init at 0.8.2 #87969
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to have a lot of /usr/local/lib that makes this difficult to use on NixOS.
https://github.com/cyberark/summon/search?q=%2Fusr%2Flocal%2Flib&unscoped_q=%2Fusr%2Flocal%2Flib
@tomberek You can specify path to provider executable via |
Hi - thanks for the contribution! Is it possible to patch it to use Also, the PR contains a separate commit that corrects your githubID in the maintainers. Please provide two commits, one for the new pkg and one for the addition to maintainer-list. |
20b9480
to
5b32dea
Compare
@stigtsp sorry for the long silence, quarantine disrupted my plans quite a bit. I rebased the commits as you asked and provided an optional patch which tries to resolve non-qualified provider names, i.e. |
|
||
subPackages = [ "cmd" ]; | ||
|
||
patches = optional patchResolver [ ./resolve-paths.patch ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be optional? I'm not sure, what do you think @tomberek
Also it would be nice with a short comment explaining why the patch is there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My reasoning to make it optional was that it changes the intended behavior of the tool, which may, theoretically, break someone's workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)