Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cue: 0.1.1 -> 0.1.2 #87960

Merged
merged 1 commit into from May 17, 2020
Merged

cue: 0.1.1 -> 0.1.2 #87960

merged 1 commit into from May 17, 2020

Conversation

eonpatapon
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit and solson May 16, 2020 17:24
nlewo
nlewo reviewed May 16, 2020
View reviewed changes
pkgs/development/tools/cue/default.nix

src = fetchgit {
url = "https://cue.googlesource.com/cue";
rev = "v${version}";
sha256 = "1qbnm3qb8jz9bljw2gb5bb9g41s5lbq4xvcaj3zgi4fc3708hlji";
sha256 = "0pmw7gnh4z5sbri8464rpwp3hbrz23zwig82nk9wdjkg1qahyy13";
};

vendorSha256 = "12w2rxp0s3i1ck0qvp2dkg9kk6pyymycdfnfxggcyg4fjshh8afg";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this doesn't need to be updated as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's a very minor release, dependencies didn't change

If I invalidate the sha:

hash mismatch in fixed-output derivation '/nix/store/4ymfcgkzq9wzv7mhv501if0kcf0wvs85-cue-0.1.2-go-modules':
  wanted: sha256:12w2rxp0s3i1ck0qvp2dkg9kk6pyymycdfnfxggcyg4fjshh8a00
  got:    sha256:12w2rxp0s3i1ck0qvp2dkg9kk6pyymycdfnfxggcyg4fjshh8afg

@CloudArtAdmins
Copy link
Contributor

I don't have cue files to test. This still built and ran for me, though.

@eonpatapon eonpatapon requested a review from nlewo May 17, 2020 07:53
@nlewo nlewo merged commit eeb1481 into NixOS:master May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@solson solson Awaiting requested review from solson

@nlewo nlewo Awaiting requested review from nlewo

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eonpatapon @CloudArtAdmins @nlewo