Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: 02/2020 backports #87961

Merged
merged 5 commits into from May 17, 2020
Merged

vscode: 02/2020 backports #87961

merged 5 commits into from May 17, 2020

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented May 16, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Roman Kuznetsov and others added 5 commits May 16, 2020 13:15
(cherry picked from commit ba774d4)
(cherry picked from commit 301905d)
(cherry picked from commit 36fb04b)
The option "--skip-getting-started" no longer exists in vscode and causes files in "$@" to not be opened.
Message from stdout: "Warning: 'skip-getting-started' is not in the list of known options, but still passed to Electron/Chromium."
"--skip-getting-started" being removed: microsoft/vscode@6a8b201

(cherry picked from commit f1e6d96)
(cherry picked from commit 91f58ec)
@eadwu
Copy link
Member Author

eadwu commented May 16, 2020

#87611 (comment)

@eadwu eadwu requested a review from kuznero May 16, 2020 17:24
@ofborg ofborg bot requested a review from Synthetica9 May 16, 2020 17:25
@marsam marsam merged commit 025deb8 into NixOS:release-20.03 May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants